Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: meeting notes from 2016-12-01 #23

Merged
merged 1 commit into from
Dec 7, 2016
Merged

doc: meeting notes from 2016-12-01 #23

merged 1 commit into from
Dec 7, 2016

Conversation

joshgav
Copy link

@joshgav joshgav commented Dec 2, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

notes from Collaboration Summit meeting

/cc @nodejs/api @nodejs/chakracore @nodejs/v8 @nodejs/spidernode @nodejs/ctc @nodejs/tsc

jasnell

This comment was marked as off-topic.

aruneshchandra

This comment was marked as off-topic.

aruneshchandra

This comment was marked as off-topic.

jasnell

This comment was marked as off-topic.

@joshgav
Copy link
Author

joshgav commented Dec 5, 2016

@aruneshchandra I cleaned up inline next steps and provided a consolidated list at the end, PTAL. Copied here for better visibility:

  • CTC to review Node-EP for abi-stable-node.
  • V8 team to review NAPI implementation.
  • NAPI team to test against more native modules in CITGM.
  • Core/CTC to land as experimental behind a build-time flag in 8.0; and to evaluate bringing out from flag when 8.0 goes LTS (Oct 2017).
  • V8 to publish branch with Fast FFI implementation; Node Core and Chakra teams to review.
  • API WG to hold checkpoint with CTC in late February/early March 2017, demo and discuss NAPI and Fast-FFI.
  • Checkpoint again in mid-July, perhaps in conjunction with a community conference.

@mhdawson @ofrobots could I get a review from you too? @ofrobots you weren't present at the meeting, but can you confirm the V8 team is on board with these next steps? [Note: @s3ththompson was present.] Thank you!

s3ththompson

This comment was marked as off-topic.

mhdawson

This comment was marked as off-topic.

@fhinkel
Copy link
Member

fhinkel commented Dec 7, 2016

Sorry to be behind on this. We're reviewing the NAPI right now. Is it OK if we have results next week? /cc @nodejs/v8

@aruneshchandra
Copy link
Contributor

@fhinkel yes its ok! BTW you are not behind :)

PR-URL: #23
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Arunesh Chandra <arunesh.chandra@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@joshgav
Copy link
Author

joshgav commented Dec 7, 2016

Updated, but I don't have push access in this repo. @mhdawson can you land? Thanks!

@aruneshchandra aruneshchandra merged commit f44a02c into nodejs:api-prototype-6.2.0 Dec 7, 2016
@aruneshchandra
Copy link
Contributor

Landed it! Thanx @joshgav

@fhinkel
Copy link
Member

fhinkel commented Dec 12, 2016

Thanks for getting the NAPI in such good shape! No major concerns from our side, I've opened a few minor PRs (#32, #33, #34).

Along the lines of to the comment in the header, experience with our API and Blink suggests all hat wrapping will come at a cost. Eager to see a performance analysis.

/cc @ofrobots

jasongin pushed a commit to jasongin/abi-stable-node that referenced this pull request Jan 26, 2017
PR-URL: nodejs#23
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Arunesh Chandra <arunesh.chandra@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants