-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: meeting notes from 2016-12-01 #23
doc: meeting notes from 2016-12-01 #23
Conversation
@aruneshchandra I cleaned up inline next steps and provided a consolidated list at the end, PTAL. Copied here for better visibility:
@mhdawson @ofrobots could I get a review from you too? @ofrobots you weren't present at the meeting, but can you confirm the V8 team is on board with these next steps? [Note: @s3ththompson was present.] Thank you! |
Sorry to be behind on this. We're reviewing the NAPI right now. Is it OK if we have results next week? /cc @nodejs/v8 |
@fhinkel yes its ok! BTW you are not behind :) |
PR-URL: #23 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Arunesh Chandra <arunesh.chandra@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Updated, but I don't have push access in this repo. @mhdawson can you land? Thanks! |
Landed it! Thanx @joshgav |
Thanks for getting the NAPI in such good shape! No major concerns from our side, I've opened a few minor PRs (#32, #33, #34). Along the lines of to the comment in the header, experience with our API and Blink suggests all hat wrapping will come at a cost. Eager to see a performance analysis. /cc @ofrobots |
PR-URL: nodejs#23 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Arunesh Chandra <arunesh.chandra@microsoft.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Checklist
Affected core subsystem(s)
doc
Description of change
notes from Collaboration Summit meeting
/cc @nodejs/api @nodejs/chakracore @nodejs/v8 @nodejs/spidernode @nodejs/ctc @nodejs/tsc