Fix implementation of napi_create_boolean #31
Conversation
|
LGTM - thanks for fixing! cc @boingoing |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
What about the similar fix for the other branches ? We at least need it in the 6.2 branch as I'm thinking we'll use that as the abi-stable-node "master" when we want to rebase onto the latest node. |
|
@mhdawson this fix is chakracore-specfic, and AFAICT api-prototype-chakracore-7.x is the only branch that contains chakracore, and therefore src/node_jsrtapi.cc. Thus, there should be no other branches to which this fix needs to be applied. |
|
@gabrielschulhof sorry should have looked more closely at what file was being changed. |
|
@mhdawson NP :) I too have often confused node_jsvmapi.cc with node_jsrtapi.cc. |
|
I was not happy with how those file names turned out. Would be great for someone to reorganize or rename them to clearly show they are v8 and jsrt implementations of napi. (drive by holla') |
|
Do I need to do anything with this PR before it can be merged? |
Need to call JsBoolToBoolean(), not JsDoubleToNumber() when creating a JS boolean from a bool. Closes: #31
Need to call JsBoolToBoolean(), not JsDoubleToNumber() when creating a JS boolean from a bool. Closes #31
gabrielschulhof
force-pushed
the
api-prototype-chakracore-7.x
branch
from
824d477 to
e2480ba
Compare
Need to call JsBoolToBoolean(), not JsDoubleToNumber() when creating a JS boolean from a bool. Closes: #31
|
Closed in e2480ba |
Need to call JsBoolToBoolean(), not JsDoubleToNumber() when creating a JS boolean from a bool. Closes: #31
This is a leftover copy/paste error that causes booleans to be rendered as numbers when they return to JS.