Property accessors (ChakraCore) #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for property descriptors including accessor callbacks - Add a data pointer for function and accessor callbacks - Add API for defining a property using a property descriptor - Update the constructor API to use property descriptors
jasongin
force-pushed
the
accessors-cc
branch
from
bd94063 to
1a660bb
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
I think this is a good idea and probably a goal at least for the chakracore branch. There are probably some good candidates for abstracting the two implementations to remove duplication but that is a different effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the ChakraCore implementation of property accessors that was already done for V8.
Note all the test case updates as well as
node_jsvmapi.handnode_jsvmapi.ccare just copied from the V8 branch. (The latter is not currently compiled, but I assume we want to keep it around and in sync to someday enable building with either V8 or CC out of the same branch.) The main work in this PR is innode_jsrtapi.cc.