-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move postject under the nodejs org #739
Comments
👍 |
I'm all for it |
+1 |
Can you link to the current project repo? |
https://github.com/nodejs/admin/blob/main/transfer-repo-into-the-org.md
|
This is the repo under discussion: https://github.com/postmanlabs/postject. The pre-requisites for transferring it make sense. @dsanders11 @RaisinTen Can you go through it, make the necessary changes in the repo and let me know once its ready for transfer? I'll handle the company logistics from Postman's side afterwards |
This is the repo under discussion: https://github.com/postmanlabs/postject. The pre-requisites for transferring it make sense. @dsanders11 @RaisinTen Can you go through it, make the necessary changes in the repo and let me know once its ready for transfer? I'll handle the company logistics afterwards |
This change adds a CODE_OF_CONDUCT.md file and a CONTRIBUTING.md file to the project. This is a requirement for transferring as documented in: https://github.com/nodejs/admin/blob/a99c444662467d596753affb2ce192250f4f4b6c/transfer-repo-into-the-org.md#step-1-get-the-repository-ready. Refs: nodejs/admin#739 Signed-off-by: Darshan Sen <raisinten@gmail.com>
This change adds a CODE_OF_CONDUCT.md file and a CONTRIBUTING.md file to the project. This is a requirement for transferring as documented in: https://github.com/nodejs/admin/blob/a99c444662467d596753affb2ce192250f4f4b6c/transfer-repo-into-the-org.md#step-1-get-the-repository-ready. Refs: nodejs/admin#739 Signed-off-by: Darshan Sen <raisinten@gmail.com> Signed-off-by: Darshan Sen <raisinten@gmail.com>
@richardlau thanks for the link, I've updated the repo and the description with the required info. @nodejs/tsc PTAL. |
Isn't it a bit early to move it under the org when we don't yet have consensus on using it ? |
I thought that we didn't have consensus on using postject by making it a part of the Node.js binary but we did have consensus on using it separately at least - nodejs/node#45066 (comment). I'd be happy to address any concerns regarding that. |
72 hours have passed after I posted #739 (comment), so I'm closing this issue now. Will transfer the repo soon! |
I'll get the right Postman approvals, etc and will transfer the repo as soon as possible. |
We have the final thumbs up. I'm transferring the project now. |
And done! https://github.com/nodejs/postject 🎉 |
I have also given the @nodejs/single-executable team |
Shouldn't they get EDIT: for reference, https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization#repository-roles-for-organizations says the |
Ah, I didn't know that. Done, now the team has the |
Btw, I have also invited the Node.js foundation npm account to be an owner of the npm package according to admin/transfer-repo-into-the-org.md Lines 51 to 53 in 201fd09
$ npm owner add nodejs-foundation postject
This operation requires a one-time password.
Enter OTP: ******
npm notice INFO: User nodejs-foundation invited to package postject successfully.
+ nodejs-foundation (postject) |
Owner: https://github.com/postmanlabs
Name of repository: postject
Repository link: https://github.com/postmanlabs/postject
The repository has the necessary code to inject arbitrary data into a binary post-compilation and also the code required for retrieving the embedded data at runtime. This is needed to make it possible for Node.js to support the creation of single executable applications. This repository makes more sense under the nodejs org instead of postmanlabs because then Node.js would have full control over the resource injector and the reader code, both of which are essential for supporting single executable applications.
It was discussed in the collab summit that we'd move postject under the nodejs org.
See @mhdawson's comment in nodejs/node#45066 (comment).
cc @nodejs/tsc @nodejs/single-executable
The text was updated successfully, but these errors were encountered: