Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move postject under the nodejs org #739

Closed
RaisinTen opened this issue Oct 21, 2022 · 18 comments
Closed

move postject under the nodejs org #739

RaisinTen opened this issue Oct 21, 2022 · 18 comments

Comments

@RaisinTen
Copy link
Contributor

RaisinTen commented Oct 21, 2022

The owner and the name of the repository, and a link to it.

Owner: https://github.com/postmanlabs
Name of repository: postject
Repository link: https://github.com/postmanlabs/postject

What the repository is for, why it should be transferred into the organization.

The repository has the necessary code to inject arbitrary data into a binary post-compilation and also the code required for retrieving the embedded data at runtime. This is needed to make it possible for Node.js to support the creation of single executable applications. This repository makes more sense under the nodejs org instead of postmanlabs because then Node.js would have full control over the resource injector and the reader code, both of which are essential for supporting single executable applications.

It was discussed in the collab summit that we'd move postject under the nodejs org.
See @mhdawson's comment in nodejs/node#45066 (comment).

cc @nodejs/tsc @nodejs/single-executable

@ovflowd
Copy link
Member

ovflowd commented Oct 21, 2022

👍

@jviotti
Copy link
Member

jviotti commented Oct 21, 2022

I'm all for it

@bnb
Copy link
Contributor

bnb commented Oct 21, 2022

+1

@jasnell
Copy link
Member

jasnell commented Oct 21, 2022

Can you link to the current project repo?

@richardlau
Copy link
Member

Can you link to the current project repo?

https://github.com/nodejs/admin/blob/main/transfer-repo-into-the-org.md

The issue should include:

  • The owner and the name of the repository, and a link to it.
  • What the repository is for, why it should be transferred into the organization.
  • Mentions of @nodejs/community-committee and @nodejs/tsc so the Community Committee and the Technical Steering Committee members can be notified about the request and weigh in.

@jviotti
Copy link
Member

jviotti commented Oct 21, 2022

This is the repo under discussion: https://github.com/postmanlabs/postject. The pre-requisites for transferring it make sense. @dsanders11 @RaisinTen Can you go through it, make the necessary changes in the repo and let me know once its ready for transfer? I'll handle the company logistics from Postman's side afterwards

@jviotti
Copy link
Member

jviotti commented Oct 21, 2022

This is the repo under discussion: https://github.com/postmanlabs/postject. The pre-requisites for transferring it make sense. @dsanders11 @RaisinTen Can you go through it, make the necessary changes in the repo and let me know once its ready for transfer? I'll handle the company logistics afterwards

RaisinTen added a commit to nodejs/postject that referenced this issue Oct 25, 2022
This change adds a CODE_OF_CONDUCT.md file and a CONTRIBUTING.md file to
the project. This is a requirement for transferring as documented in: https://github.com/nodejs/admin/blob/a99c444662467d596753affb2ce192250f4f4b6c/transfer-repo-into-the-org.md#step-1-get-the-repository-ready.

Refs: nodejs/admin#739
Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen added a commit to nodejs/postject that referenced this issue Oct 25, 2022
This change adds a CODE_OF_CONDUCT.md file and a CONTRIBUTING.md file to
the project. This is a requirement for transferring as documented in: https://github.com/nodejs/admin/blob/a99c444662467d596753affb2ce192250f4f4b6c/transfer-repo-into-the-org.md#step-1-get-the-repository-ready.

Refs: nodejs/admin#739
Signed-off-by: Darshan Sen <raisinten@gmail.com>

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen
Copy link
Contributor Author

@richardlau thanks for the link, I've updated the repo and the description with the required info.

@nodejs/tsc PTAL.

@targos
Copy link
Member

targos commented Oct 25, 2022

Isn't it a bit early to move it under the org when we don't yet have consensus on using it ?

@RaisinTen
Copy link
Contributor Author

I thought that we didn't have consensus on using postject by making it a part of the Node.js binary but we did have consensus on using it separately at least - nodejs/node#45066 (comment). I'd be happy to address any concerns regarding that.

@RaisinTen
Copy link
Contributor Author

72 hours have passed after I posted #739 (comment), so I'm closing this issue now. Will transfer the repo soon!

@jviotti
Copy link
Member

jviotti commented Oct 28, 2022

I'll get the right Postman approvals, etc and will transfer the repo as soon as possible.

@jviotti
Copy link
Member

jviotti commented Oct 28, 2022

We have the final thumbs up. I'm transferring the project now.

@jviotti
Copy link
Member

jviotti commented Oct 28, 2022

And done! https://github.com/nodejs/postject 🎉

@RaisinTen
Copy link
Contributor Author

I have also given the @nodejs/single-executable team Write access to the repo. Feel free to raise any concerns regarding that as issues in the repo. Thanks a lot everyone! 🎉

@aduh95
Copy link
Contributor

aduh95 commented Oct 28, 2022

I have also given the @nodejs/single-executable team Write access to the repo.

Shouldn't they get Maintainer role instead? That's what I've been doing when transferring repo, I'm never sure which is more appropriate though.

EDIT: for reference, https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization#repository-roles-for-organizations says the Maintain role is recommended for folks "who need to manage the repository without access to sensitive or destructive actions".

@RaisinTen
Copy link
Contributor Author

Ah, I didn't know that. Done, now the team has the Maintain role. 👍

@RaisinTen
Copy link
Contributor Author

Btw, I have also invited the Node.js foundation npm account to be an owner of the npm package according to

If the transferred repository has one or more associated npm packages for releases,
[the Node.js foundation npm account](https://www.npmjs.com/~nodejs-foundation)
should be added to the list of the npm collaborators of the packages. The account
:

$ npm owner add nodejs-foundation postject
This operation requires a one-time password.
Enter OTP: ******
npm notice INFO: User nodejs-foundation invited to package postject successfully.
+ nodejs-foundation (postject)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants