-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add social-team.md #494
Conversation
since this affects both the TSC and CommComm: @nodejs/tsc @nodejs/community-committee ❤️ |
Co-Authored-By: Richard Lau <riclau@uk.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! ✔︎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great 🎉
Sorry to be late to this party, but should there be annual recertification like we do for Moderation Team? That has been really good for removing inactive members, IMO. |
@Trott that sounds like an excellent idea to me. Added almost verbatim section to what Moderation uses. |
I'll give this until Monday before merging since it is a relatively impactful change that does add a non-trivial set of work to the project. If there are no -1s and any further responses are able to be addressed by Monday, I'm going to merge. Again, one last ping to @nodejs/tsc and @nodejs/community-committee for eyes ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
As a final heads up, going to merge this today @nodejs/community-committee @nodejs/tsc pending any -1s. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnb Just a few readability fixes. Otherwise, looks great (thus approved)! 😎
Thanks a million for kicking this off! 🚀
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Co-Authored-By: Ben Michel <ben@obensource.com>
Given that those changes were readability nits that don't meaningfully change the contents and @obensource approved, I'm going to merge this. Thank you all for your feedback - excited to see this move forward ❤️ I'll be working with @rginn on getting the auth for the accounts to the Social Team as appropriate 👍 |
🎉🎉🎉 Thanks for making this happen @bnb! 👏👏👏 |
This PR adds the foundation for the Social Team, addressing #454. Took a few more "next week"s than I'd anticipated, but here it is 🙇