test: check erasable namespaces are supported #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-ippolito
force-pushed
the
check-name-spaces
branch
from
918bb0f to
42fce64
Compare
|
Can you file an issue on swc? |
|
You may also want to test the error cases as well; there are some interesting ones like empty expressions (which I'm hoping swc also gets right) |
marco-ippolito
force-pushed
the
check-name-spaces
branch
from
42fce64 to
37dba0b
Compare
|
Added tests case that should fail |
marco-ippolito
force-pushed
the
check-name-spaces
branch
from
37dba0b to
3d84c70
Compare
|
@nodejs/typescript PTAL |
jakebailey
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kdy1 I think we should support type stripping of empty namespaces because they are erasable and are supported by erasableSyntaxOnly
cc @nodejs/typescript
Tests copied from bloomberg/ts-blank-space#32