Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tools): enclose test glob patterns in quotes #44

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

klaemo
Copy link
Contributor

@klaemo klaemo commented Aug 5, 2024

If you want to rely on node’s test runner’s glob expansion the glob patterns should be enclosed in quotes. Otherwise the shell will do the glob expansion which can have different behaviors depending on the system.

The glob patterns should be enclosed in double quotes on the command line to prevent shell expansion, which can reduce portability across systems.

https://nodejs.org/docs/latest/api/test.html#running-tests-from-the-command-line

@klaemo klaemo changed the title Enclose test glob patterns in quotes chore(tools): enclose test glob patterns in quotes Aug 5, 2024
@marco-ippolito marco-ippolito merged commit 8052e6b into nodejs:main Aug 6, 2024
8 checks passed
@klaemo klaemo deleted the patch-2 branch August 6, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants