Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update SWC to v1.7.14 #69

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

github-actions[bot]
Copy link

This PR updates SWC to v1.7.14.
View the SWC changelog for more information.

@marco-ippolito marco-ippolito force-pushed the chore/update-swc-1.7.14 branch from f7cb645 to 3a8ff0d Compare August 19, 2024 18:13
@marco-ippolito
Copy link
Member

marco-ippolito commented Aug 19, 2024

@robpalme output looks now correct right?

test("test native class properties", (t) => {
	const inputCode = `
	class Foo {
		x = console.log(1)
		constructor(public y = console.log(2)) {
			console.log(3)
		}
	}`;
	const { code } = transformSync(inputCode, {
		mode: "transform",
		sourceMap: true,
		transform: {
			verbatimModuleSyntax: true,
			nativeClassProperties: true,
		},
	});
	console.log(code);
	t.assert.snapshot(code);
});
class Foo {
    y;
    x = console.log(1);
    constructor(y = console.log(2)){
        this.y = y;
        console.log(3);
    }
}

@robpalme
Copy link

robpalme commented Aug 19, 2024

Yes, it is now correct @marco-ippolito

Good job, all.


Follow-on opinion:

Given that both these options (VMS & NCP) should be on by default in Node, I would suggest providing those defaults in Amaro to simplify the Node side. (Whilst still allowing Node to override them later if need be.)

@marco-ippolito marco-ippolito merged commit 9fe26d2 into main Aug 19, 2024
8 checks passed
@marco-ippolito marco-ippolito deleted the chore/update-swc-1.7.14 branch August 19, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants