feat: add limit-commits option #67
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new option that can be used to set a maximum number of commits that branch-diff should work with prior to starting requesting GitHub APIs. This is an essential feature to help releasers avoid exceeding GitHub API secondary rate limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last time I had to fight GitHub API secondary rate limits for a very long-lived LTS release I ended up writing this (based on knowledge shared from @BethGriggs) to help me unblock retrieving a list of commits from branch-diff.
Although it might be functional, the current API here is very clunky and requires the user to find out how many commits are already ignored in order to provide that value to
skip-commitsand from a combination ofskip-commitsandlimit-commitshopefully cut out a limited enough series of commit that will not trigger GitHub API limits.Opening this as a draft so that we can discuss better alternatives.