Auto start CI for collaborators

[BridgeAR]

Hey, is there a easy possibility to automatically run the CI for any PR that was opened by a collaborator and also in case there is a update? That would ease the work for all of us when opening and maintaining PRs.

I guess we might need a bot to do this but right now I have to little insight into the build things to know what might be required / what should be done. Any ideas / suggestions?

[gibfahn]

Yes this is possible, in fact we already started working on it, the reason it stalled was because no-one had the time to really push it forward.

The bot that co-ordinates it would be the github-bot.

See also:

nodejs/github-bot#82
nodejs/github-bot#146

[BridgeAR]

That is great! Do you know what has to be done to get this going again? I would really love to get this.

[gibfahn]

That is great! Do you know what has to be done to get this going again? I would really love to get this.

What we were doing before was testing that it works with CitGM. However we hit failures where builds weren't triggered (see nodejs/github-bot#146).

So someone needs to basically fix that in something that isn't nodejs/node (e.g. in citgm), and once we have it stable we can propose it for nodejs/node and have that discussion.

[mhdawson]

I'd recommend that it only start after there is at least one additional approval for the PR.

[gibfahn]

I'd recommend that it only start after there is at least one additional approval for the PR.

I'd say as a first iteration just have it be triggered manually by pinging the bot, as it's done now in CitGM. If that works we can look at auto-running CI afterwards.

@BridgeAR if we want to put it in core, I guess the next option would be raising a PR in core to document how this works, we can use that PR to gather consensus about how it should work.

It might also be a good idea to try enabling it in a few more projects in node as well (e.g. libuv or node-gyp) and see how it goes, if it's working well in several projects, that'd make it more acceptable.

[bnoordhuis]

nodejs/github-bot#146 was closed. Does that mean this is good to go now? I'd be a-okay with enabling it for libuv and node-gyp as well.

[LucaLanziani]

Sorry I'm new here so I might be asking stupid questions.
What's the reason to use a bot?
This can be done by jenkins itself, the only limit might be the fact that the testing is going to be just on collaborator's PRs

[maclover7]

@LucaLanziani The reason to do this via nodejs/github-bot is because we already have many GitHub automation tasks that live in that Node app. Also, the Build WG lately has been moving toward keeping as much configuration in-repo as possible

[LucaLanziani]

@maclover7 yeah I supposed one reason was the access. My idea was to use something similar to https://jenkins.io/doc/book/pipeline/jenkinsfile/
The jenkinsfile will live in the repo you want to test and jenkins will scan the repos and load the jobs/set the hooks ect ect.

[maclover7]

Largely solved by nodejs/github-bot#178, nodejs/github-bot#180

[refack]

Largely solved by

So still not completely solved, please keep WIPs open, otherwise we lose track.

[mmarchini]

Can we have a list of tasks we need to accomplish before closing this?

My understanding is that the only thing missing is to enable this for libuv and node-gyp. Am I missing something?

[Trott]

I think the auto-kickoff of the Lite job for Collaborators solves this. I wouldn't want a full CI kickoff for doc edits and whatnot. I think the current situation is 👍. Feel free to re-open if you think that's misguided. Just doing my best to triage right now.