Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: update to use pipeline #178

Merged
merged 1 commit into from
Jun 9, 2018
Merged

Conversation

maclover7
Copy link
Contributor

Refs: https://github.com/nodejs-private/secrets/pull/20
Refs: #175

Will now post comments upon pipeline builds being run

Refs: https://github.com/nodejs-private/secrets/pull/20
Refs: nodejs#175

Will now post comments upon pipeline builds being run
@maclover7 maclover7 requested a review from phillipj June 9, 2018 17:09
@maclover7
Copy link
Contributor Author

@phillipj, would you be able to review/push the secrets updates, and then review/push this PR?

phillipj

This comment was marked as off-topic.

@phillipj
Copy link
Member

phillipj commented Jun 9, 2018

would you be able to review/push the secrets updates

Sure! I'll get this pushed later tonight.

@phillipj phillipj merged commit 8fdb3db into nodejs:master Jun 9, 2018
@phillipj
Copy link
Member

phillipj commented Jun 9, 2018

This is now live in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants