Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-node: count jenkins pipeline and/or Travis as effective CI runs #259

Closed
joyeecheung opened this issue Jun 21, 2018 · 2 comments
Closed

Comments

@joyeecheung
Copy link
Member

Refs: nodejs/github-bot#178 that runs the jenkins pipeline for collaborator PRs. The bot currently comments on the PR with a link to the job after the build is started.
Refs: nodejs/node#21059 which runs the Travis CI for non-collabortor PRs. The existence of the job can only be tracked in the Github status API or via Travis API.

Both of them only serve the same purpose as the original Lite CI. For non-doc-only PRs we still require a full CI triggered by human (for now at least).

One way to fix this easily is, instead of only looking at the thread for CI links, also look at the status API to find jobs run for the last effective commit of the PR.
(Personally, I would want a warning to remind people to post the link to the PR because when the PR is landed, no one will ever know about those links if they only exist in the status API. I think someone raised concern about that before)

@joyeecheung
Copy link
Member Author

This is how the pipeline link looks: nodejs/node#21430 (comment)

@vsemozhetbyt
Copy link
Contributor

CI-lite detection is also broken now. Refs: nodejs/node#21938

joyeecheung added a commit to joyeecheung/node-core-utils that referenced this issue Mar 22, 2019
johnfrench3 pushed a commit to johnfrench3/core-utils-node that referenced this issue Nov 2, 2022
renawolford6 added a commit to renawolford6/node-dev-build-core-utils that referenced this issue Nov 10, 2022
Developerarif2 pushed a commit to Developerarif2/node-core-utils that referenced this issue Jan 27, 2023
gerkai added a commit to gerkai/node-core-utils-project-build that referenced this issue Jan 27, 2023
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this issue Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants