auth & ncu-ci: add jenkins authentication, refactor ci parsers #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
commented
Jun 21, 2018
| let { username, jenkins_token } = getMergedConfig(); | ||
| if (!username || !jenkins_token) { | ||
| process.stdout.write( | ||
| 'Get your Jenkins API token in https://ci.nodejs.org/me/configure ' + |
There was a problem hiding this comment.
I have not added any documentation on how to get the Jenkins API token but it's pretty obvious if you follow this error message. It's only used when you use ncu-ci anyway.
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 80.46% 80.12% -0.34%
==========================================
Files 21 22 +1
Lines 1203 1253 +50
==========================================
+ Hits 968 1004 +36
- Misses 235 249 +14
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #257
After this #259 should be easier to fix as well