Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncu-ci: add --cache and progress in display #328

Merged
merged 2 commits into from
Mar 22, 2019

Conversation

joyeecheung
Copy link
Member

No description provided.

@joyeecheung
Copy link
Member Author

cc @nodejs/automation

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #328 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   73.85%   73.83%   -0.02%     
==========================================
  Files          22       22              
  Lines        1415     1414       -1     
==========================================
- Hits         1045     1044       -1     
  Misses        370      370
Impacted Files Coverage Δ
lib/ci/ci_result_parser.js 48.61% <ø> (ø) ⬆️
lib/ci/ci_type_parser.js 80.95% <100%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e0ff00...d77d255. Read the comment docs.

@@ -86,7 +86,7 @@ const CI_TYPES = new Map([
[LITE_PR_PIPELINE, {
name: 'Lite PR Pipeline',
jobName: 'node-test-pull-request-lite-pipeline',
pattern: /job\/node-test-pull-request-lite-pipeline\/(\d+)\/pipeline/,
pattern: /node-test-pull-request-lite-pipeline\/(\d+)\/pipeline/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unrelated change? (If it allows the GitHub bot posted links then that's 💯 👍 but should be in its own commit and probably have tests if that's the intention.)

@joyeecheung
Copy link
Member Author

@richardlau Looks like I accidentally added some unrelated changes...anyway since I am at it, fixed #259 in the second commit

@joyeecheung joyeecheung merged commit 311a0d1 into nodejs:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants