ncu-ci: add --cache and progress in display #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nodejs/automation |
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
- Coverage 73.85% 73.83% -0.02%
==========================================
Files 22 22
Lines 1415 1414 -1
==========================================
- Hits 1045 1044 -1
Misses 370 370
Continue to review full report at Codecov.
|
BridgeAR
approved these changes
Mar 22, 2019
richardlau
reviewed
Mar 22, 2019
| @@ -86,7 +86,7 @@ const CI_TYPES = new Map([ | |||
| [LITE_PR_PIPELINE, { | |||
| name: 'Lite PR Pipeline', | |||
| jobName: 'node-test-pull-request-lite-pipeline', | |||
| pattern: /job\/node-test-pull-request-lite-pipeline\/(\d+)\/pipeline/, | |||
| pattern: /node-test-pull-request-lite-pipeline\/(\d+)\/pipeline/, | |||
There was a problem hiding this comment.
This is an unrelated change? (If it allows the GitHub bot posted links then that's 💯 👍 but should be in its own commit and probably have tests if that's the intention.)
|
@richardlau Looks like I accidentally added some unrelated changes...anyway since I am at it, fixed #259 in the second commit |
richardlau
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.