Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install nasm on Windows for OpenSSL-1.1.0 #1190

Closed
shigeki opened this issue Mar 23, 2018 · 5 comments
Closed

Install nasm on Windows for OpenSSL-1.1.0 #1190

shigeki opened this issue Mar 23, 2018 · 5 comments

Comments

@shigeki
Copy link

shigeki commented Mar 23, 2018

OpenSSL-1.1.0 require the NASM http://www.nasm.us/ for building assemble codes as described in
https://github.com/openssl/openssl/blob/1bfb7860cb81cf6431308c244a4967e41806a919/NOTES.WIN#L21-L24
It also needs for Node build after upgradeing OpenSSL-1.1.0.

Please install it on the all Windows machines for ci checking and release building. The current latest stable version is 2.13.03.
joaocgreis added a commit to JaneaSystems/build that referenced this issue Mar 23, 2018
@joaocgreis
setup,win: add NASM
294bd0d 
Fixes: nodejs#1190
@joaocgreis joaocgreis mentioned this issue Mar 23, 2018
Merged
@joaocgreis
Copy link
Member

PR: #1192

Script already run on all machines, NASM is ready to use. Let me know if anything is wrong.

@shigeki
Copy link
Author

shigeki commented Mar 24, 2018

@joaocgreis Thanks for your quick work. But the configure was failed to use nasm in CI because the output of nasm -v cannot be obtained as https://ci.nodejs.org/job/node-compile-windows/16716/label=win-vs2017/consoleFull

configure  --dest-cpu=x64
WARNING: No acceptable ASM compiler found!
         Please make sure you have installed nasm from http://www.nasm.us
         and refer BUILDING.md.

Could you confirm the output of nasm -v ?

C:\Users\ohtsu\Desktop\github\shigeki\node>nasm -v
NASM version 2.13.03 compiled on Feb  7 2018

If nasm was installed with http://www.nasm.us/pub/nasm/releasebuilds/2.13.03/win64/nasm-2.13.03-installer-x64.exe, the path is C:\Program Files\NASM>.

@joaocgreis
Copy link
Member

@shigeki the NASM installer does not add the executable location to the Path. I could add it in all CI machines, but I believe a better solution is to look for it in the default install location. This is to make it easier for people starting in node development (for example in Code & Learn).

Here is my suggestion for how to do it: JaneaSystems/node@3a2545b , feel free to take any or all of it and change as you see fit. It is a fixup for your build: add openssl-1.1.0 support commit, also includes two lines in BUILDING.md.

CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/16642/

shigeki pushed a commit to shigeki/node that referenced this issue Mar 25, 2018
@joaocgreis @shigeki
build, tools, win: add nasm detection for OpenSSL
c917bce 
OpenSSL-1.1.0 requires the nasm assembler for building asm files on
Windows. This finds nasm at \Program Files\NASM\nasm.exe or
\ProgramFiles(x86)\NASM\nasm.exe in vcbuild.bat for users who did not
add its path in their enviroments.

Fixes: nodejs/build#1190
@shigeki
Copy link
Author

shigeki commented Mar 25, 2018

@joaocgreis Thanks and I appreciate your patch. I was not ware that vcbuild.bat had such a detection of commands. CI was good in https://ci.nodejs.org/job/node-compile-windows/16744 and I also confirmed in my azure vm where the nasm path was removed.

I added your patch in shigeki/node@c917bce as to follow the commit message guideline and lint-md and I would like your commit to be included in my PR.
Please let me know if word or something is wrong. Thanks, agin.

@shigeki shigeki closed this as completed Mar 25, 2018
joaocgreis added a commit that referenced this issue Apr 3, 2018
@joaocgreis
setup,win: add NASM
ef329a8 
Fixes: #1190
joaocgreis added a commit that referenced this issue Apr 3, 2018
@joaocgreis
setup,win: add NASM
9a58175 
Fixes: #1190
PR-URL: #1192
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
shigeki pushed a commit to shigeki/node that referenced this issue Apr 4, 2018
@joaocgreis @shigeki
build, tools, win: add nasm detection for OpenSSL
cea6e02 
OpenSSL-1.1.0 requires the nasm assembler for building asm files on
Windows. This finds nasm at \Program Files\NASM\nasm.exe or
\ProgramFiles(x86)\NASM\nasm.exe in vcbuild.bat for users who did not
add its path in their enviroments.

Fixes: nodejs/build#1190
shigeki pushed a commit to shigeki/node that referenced this issue Apr 5, 2018
@joaocgreis @shigeki
build, tools, win: add nasm detection for OpenSSL
53a63ef 
OpenSSL-1.1.0 requires the nasm assembler for building asm files on
Windows. This finds nasm at \Program Files\NASM\nasm.exe or
\ProgramFiles(x86)\NASM\nasm.exe in vcbuild.bat for users who did not
add its path in their enviroments.

Fixes: nodejs/build#1190
tniessen pushed a commit to tniessen/node that referenced this issue Apr 6, 2018
@joaocgreis @tniessen
build, tools, win: add nasm detection for OpenSSL
a191f6b 
OpenSSL-1.1.0 requires the nasm assembler for building asm files on
Windows. This finds nasm at \Program Files\NASM\nasm.exe or
\ProgramFiles(x86)\NASM\nasm.exe in vcbuild.bat for users who did not
add its path in their enviroments.

Fixes: nodejs/build#1190
shigeki pushed a commit to shigeki/node that referenced this issue Apr 9, 2018
@joaocgreis @shigeki
build, tools, win: add nasm detection for OpenSSL
f584f35 
OpenSSL-1.1.0 requires the nasm assembler for building asm files on
Windows. This finds nasm at \Program Files\NASM\nasm.exe or
\ProgramFiles(x86)\NASM\nasm.exe in vcbuild.bat for users who did not
add its path in their enviroments.

Fixes: nodejs/build#1190
shigeki pushed a commit to nodejs/node that referenced this issue Apr 9, 2018
@joaocgreis @shigeki
build, tools, win: add nasm detection for OpenSSL
eec659c 
OpenSSL-1.1.0 requires the nasm assembler for building asm files on
Windows. This finds nasm at \Program Files\NASM\nasm.exe or
\ProgramFiles(x86)\NASM\nasm.exe in vcbuild.bat for users who did not
add its path in their enviroments.

Fixes: nodejs/build#1190
Fixes: #4270
PR-URL: #19794
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@ostropik
Copy link

ostropik commented Nov 20, 2021 •
edited
Loading

Spend 2 hours, using a youtube sample which based on ActiveState perl.
Then install:

strawberry-perl-5.32.1.1-32bit.msi
nasm-2.15.05-installer-x64.exe

Checked PATH sys vars

perl Configure VC-WIN32 --debug --prefix=x:\WinProjects\Libs\openssl\Debug --openssldir=x:\WinProjects\Libs\openssl\SSL no-shared
echo clearing...
nmake clean
echo building...
nmake
echo installing...
nmake install

yeah...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joaocgreis @shigeki @ostropik