Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler missing on smartos 16 machines? #1327

Closed
targos opened this issue Jun 8, 2018 · 17 comments
Closed

Assembler missing on smartos 16 machines? #1327

targos opened this issue Jun 8, 2018 · 17 comments

Comments

@targos
Copy link
Member

targos commented Jun 8, 2018

node-test-commit-smartos is consistently failing on smartos16-64 with this message:

04:37:19 python ./configure 
04:37:20 WARNING: C++ compiler too old, need g++ 4.9.4 or clang++ 3.4.2 (CXX=g++)
04:37:20 ERROR: Did not find a new enough assembler, install one or build with
04:37:20        --openssl-no-asm.
04:37:20        Please refer to BUILDING.md
04:37:20 make: *** [Makefile:462: build-ci] Error 1
04:37:20 Build step 'Execute shell' marked build as failure
04:37:20 Checking ^not ok
@maclover7
Copy link
Contributor

Re-running playbook on machines, hopefully may fix

@maclover7
Copy link
Contributor

@targos
Copy link
Member Author

targos commented Jun 8, 2018

Looking good so far. Thanks!

@maclover7
Copy link
Contributor

Rebuild at https://ci.nodejs.org/job/node-test-commit-smartos/18225/ looks to be passing, going to close this out for now. Please reopen if happens again

@Trott
Copy link
Member

Trott commented Jun 8, 2018

It's back....

@Trott Trott reopened this Jun 8, 2018
@Trott
Copy link
Member

Trott commented Jun 8, 2018

https://ci.nodejs.org/job/node-test-commit-smartos/18227/nodes=smartos16-64/console

12:53:02 ERROR: Did not find a new enough assembler, install one or build with
12:53:02        --openssl-no-asm.
12:53:02        Please refer to BUILDING.md

@Trott
Copy link
Member

Trott commented Jun 8, 2018

Is the right thing to do this?

ansible-playbook playbooks/jenkins/worker/create.yml --limit "test-joyent-smartos16-x64-1"

Or something else? I'm not sure if that's the playbook to rebuild in this case. (Doesn't work for me in any event, but I'll try to figure out why that playbook doesn't work when run from my machine if it's the right one to run.)

@Trott
Copy link
Member

Trott commented Jun 8, 2018

Seems like pkgin in llvm-3.8.0nb2 would be likely to fix the issue. Going to try that on test-joyent-smartos16-x64-1 and see what happens.

@Trott
Copy link
Member

Trott commented Jun 8, 2018

Nope, didn't fix it.

@Trott
Copy link
Member

Trott commented Jun 8, 2018

I did pkgin rm llvm-3.8.0nb2 to remove the package I installed.

The problem appears to be that configure is not detecting that gas is installed. /opt/local/bin/gas --version reports the version as 2.26. The script wants 2.23 or later, but it appears that get_gas_version is returning 0, so something is up in that function I guess?

@Trott
Copy link
Member

Trott commented Jun 8, 2018

I was stepping through the Python code and this started working. I hope someone fixed it... because otherwise... this is mysterious, in a bad way. :-D

@Trott
Copy link
Member

Trott commented Jun 8, 2018

Only login besides me is from Cambridge, Massachussetts. Sounds like @refack fixed it?

@refack
Copy link
Contributor

refack commented Jun 8, 2018

Sorry I'm trying to fix it, but getting weird stuff

@refack
Copy link
Contributor

refack commented Jun 8, 2018

As in I have no idea why it sometimes work, and sometimes not.

@refack
Copy link
Contributor

refack commented Jun 8, 2018

Well it is nodejs/node#20394.
In some situations on smartos you cannot change the locale.

@Trott
Copy link
Member

Trott commented Jun 8, 2018

In some situations on smartos you cannot change the locale.

Interesting. Any idea what those situations are?

@Trott
Copy link
Member

Trott commented Jun 8, 2018

Looks like it works with setting LC_ALL to en_US.UTF-8 instead of just en_US.

targos pushed a commit to nodejs/node that referenced this issue Jun 10, 2018
PR-URL: #21220
Fixes: nodejs/build#1327
Refs: #20394
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit to nodejs/node that referenced this issue Jun 13, 2018
PR-URL: #21220
Fixes: nodejs/build#1327
Refs: #20394
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants