Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-test-known-issues, is this job used? can it be deleted? #1874

Closed
sam-github opened this issue Jul 24, 2019 · 4 comments
Closed

node-test-known-issues, is this job used? can it be deleted? #1874

sam-github opened this issue Jul 24, 2019 · 4 comments

Comments

@sam-github
Copy link
Contributor

quoting @richardlau

I do wonder if that job is still in-use. known_issues tests are run by default in the CI now for Node.js 10 (since 10.9.0, nodejs/node#21910) and above. It doesn't look like that job is chained to any of the regular CI jobs (also indicated by the low build job numbers) and if someone needs to do one-off known_issues test runs they can always use https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/.

In agreement with @rvagg 's points about the CI being too ambitious to be tractable, I'd like to delete the job if its unused -- or prefix the job name with archived- to indicate it isn't used or maintained, or whatever the convention here is to clean up unused jobs.

@sam-github
Copy link
Contributor Author

@Trott in particular, do you have an opinion?

@richardlau
Copy link
Member

(Link to the job being discussed: https://ci.nodejs.org/job/node-test-known-issues/)

@Trott
Copy link
Member

Trott commented Jul 24, 2019

I have not used that job in a long time, if ever. I'm totally OK with it going away.

@sam-github
Copy link
Contributor Author

I renamed it with an archive- prefix, and changed the description to

run make/vcbuild test-known-issues -- to be deleted, see #1874

I'm nervous to outright delete it, do we have ways of bringing them back if some infrequent user of the job panics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants