Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Location of ARMv7 binaries #197

Closed
phillipj opened this issue Sep 18, 2015 · 6 comments
Closed

Location of ARMv7 binaries #197

phillipj opened this issue Sep 18, 2015 · 6 comments

Comments

@phillipj
Copy link
Member

While working on verifying the uploaded binaries on /dist/ for nodejs.org #156 I noticed the location of ARMv7 binaries have changed between v4.0.0 and 4.1.1

armv7l: https://nodejs.org/dist/v4.0.0/node-v4.0.0-linux-armv7l.tar.xz

armv7: https://nodejs.org/dist/v4.1.0/node-v4.1.0-linux-armv7.tar.gz

Was this an intentional change?

P.S. we're currently linking to the wrong path for v4.1.1 in the release blog post.
phillipj added a commit to nodejs/nodejs.org that referenced this issue Sep 18, 2015
@phillipj
Quickfix for wrong ARMv7 binary URL for v4.1.0.
8007480 
ARMv7 URL changed between v4.0.0 and v4.1.0 but this
was not updated in the release blog post template.

Refs nodejs/build#197
@rvagg
Copy link
Member

rvagg commented Sep 18, 2015

Whoa, not great, must be because I replaced the ARMv7 build machine and the original config must have this wrong.

@Fishrock123 I've copied those files back in to staging and renamed them properly, could you run a promote again to get them copied in and signed? Then, after 1/2 a day or so we'll run it again and remove the armv7 versions but in between we'll have both.

@rvagg
Copy link
Member

rvagg commented Sep 18, 2015

fixed in setup @ 77c98f2

@Fishrock123
Copy link
Contributor

Re-promoted.

@phillipj
Copy link
Member Author

@rvagg @Fishrock123 when you remove the armv7 file from /dist/, please remember to revert my quickfix nodejs/nodejs.org@8007480

@phillipj
Copy link
Member Author

.. + altering the filename in the shasums list

@rvagg
Copy link
Member

rvagg commented Sep 19, 2015

thinking now that we could just leave them there, at least until the next release comes out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rvagg @Fishrock123 @phillipj