Update FreeBSD hosts to 12.4 or 13.x

[targos]

They are currently on 12.2, now EoL.

I don't know if updating to 12.4 would be a breaking change.

FreeBSD 12 will be EoL on December 31, 2023, so upgrading to 13 is something we might want to do soon anyway.

https://www.freebsd.org/releases/
https://www.freebsd.org/security/#sup

[vtjnash]

Is this related to why the FreeBSD worker failed to launch on the latest libuv test job: https://ci.nodejs.org/job/libuv-test-commit-freebsd/2152/

[targos]

I can't say. I have issues with the current FreeBSD hosts regarding C++20 support: https://ci.nodejs.org/job/node-test-commit-freebsd/49404/nodes=freebsd12-x64/console

[targos]

I'll try to update https://ci.nodejs.org/manage/computer/test-digitalocean-freebsd12-x64-1/ to 12.4 today.

[targos]

Test run: https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd12-x64/49577/console

Clang is now on version 13.0.0, which should be enough for C++20.

[targos]

Above test failed with:

15:28:02 not ok 3746 abort/test-signal-handler
15:28:02   ---
15:28:02   duration_ms: 0.189
15:28:02   severity: fail
15:28:02   exitcode: 1
15:28:02   stack: |-
15:28:02     node:assert:400
15:28:02         throw err;
15:28:02         ^
15:28:02     
15:28:02     AssertionError [ERR_ASSERTION]: child.signal = SIGBUS
15:28:02         at Object.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd12-x64/test/abort/test-signal-handler.js:22:3)
15:28:02         at Module._compile (node:internal/modules/cjs/loader:1196:14)
15:28:02         at Object.Module._extensions..js (node:internal/modules/cjs/loader:1250:10)
15:28:02         at Module.load (node:internal/modules/cjs/loader:1074:32)
15:28:02         at Function.Module._load (node:internal/modules/cjs/loader:909:12)
15:28:02         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
15:28:02         at node:internal/main/run_main_module:22:47 {
15:28:02       generatedMessage: false,
15:28:02       code: 'ERR_ASSERTION',
15:28:02       actual: false,
15:28:02       expected: true,
15:28:02       operator: '=='
15:28:02     }
15:28:02   ...

New run: https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd12-x64/49583/console

[targos]

The test is definitely broken by this upgrade. I put the machine offline for now but it means we only have one left.

/cc @nodejs/platform-freebsd

[targos]

Suggested fix for the test: nodejs/node#47851

[targos]

Both machines were updated to v12.4