assets: additional asset for v11.x #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
approved these changes
Jan 29, 2019
|
Is it needed for v10.x as well (Ref nodejs/node#22716)? |
|
@refack I just took a peak at the assets for the release that needs to be promoted today and not seeing that file. |
|
From the description in nodejs/node#25019, it looks like it wasn't intended to make this part of the published files? |
|
hmmmm it has continued to be in the built assets so perhaps we need to revisit this? /cc @joyeecheung |
AFAIK they are supposed to be published (nodejs/node#22405). They are what enable the |
richardlau
added a commit
to richardlau/build
that referenced
this pull request
Apr 9, 2020
`docs/apilinks.json` was added in v10.15.3. Refs: nodejs/node#25019 Refs: nodejs#1673 Signed-off-by: Richard Lau <riclau@uk.ibm.com>
rvagg
pushed a commit
that referenced
this pull request
Apr 13, 2020
`docs/apilinks.json` was added in v10.15.3. Refs: nodejs/node#25019 Refs: #1673 Signed-off-by: Richard Lau <riclau@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node#22405
Refs: nodejs/node#25019