Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright notice to install-xcode.sh #1981

Merged
merged 2 commits into from
Oct 22, 2019

Conversation

AshCripps
Copy link
Member

The install-xcode script originates from this blog post - https://derflounder.wordpress.com/2015/02/02/installing-the-xcode-command-line-tools-on-10-7-x-and-later/

Which is hosted in github here - https://github.com/rtrouton/rtrouton_scripts/blob/master/rtrouton_scripts/install_xcode_command_line_tools/install_xcode_command_line_tools.sh

Under the MIT license here - https://github.com/rtrouton/rtrouton_scripts/blob/master/LICENSE

Ive edited the script to have the copyright inside and a link to the original repo. Let me know if I need to add anything else or if the format is wrong.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor improvement might be to grab the current commit rather than master for stability, go to the file and press y and the URL will update.
Other than that, good catch.

@AshCripps
Copy link
Member Author

@rvagg Thanks, ive edited the url as you said

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github sam-github merged commit 946dbdf into nodejs:master Oct 22, 2019
@AshCripps AshCripps deleted the fix-copyright branch October 23, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants