-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
banish CentOS 5 #1984
banish CentOS 5 #1984
Conversation
These four jobs have been disabled nodejs/citgm#741 (comment) and can probably be removed given nobody has complained.
I can't see this job on ci.nodejs.org. |
Because it's super-secret-private. Access only by |
Running citgm is not part of the documented sec release process, though I guess we would run it if we were concerned about the impact of a change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -12,7 +12,6 @@ def buildExclusions = [ | |||
// Machine Label, Build Type, Node Version | |||
|
|||
// Linux ------------------------------------------------- | |||
[ /^centos5/, anyType, gte(8) ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure that all jobs referencing these nodes are updated before committing this otherwise they will start scheduling jobs against them (since this script is "don't allow if" so if the line is removed it is allowed).
Have done the Jenkins bit first, removed from:
and in ci-release:
no traces in job config files now |
5248e53
to
24c7bc8
Compare
Overdue. CentOS 5 has been idle since we dropped Node 6. Let's get rid of any trace of it as a cathartic experience.
On top of the changes to the repo, these machines will need to be unprovisioned and removed from jenkins:
iojs+release will need centos5-x64 and centos5-x86 removed from it.
The configs for these jobs in ci.nodejs.org reference "centos5" in some form, presumably just removing the label: