Enable jenkins testing on AIX71

[AshCripps]

Start to enable testing to be done on the new AIX71 machines.

I cant remember if @sam-github added the label to node-test-commit-aix or not

also does anyType cover both test and release or just test?

See: #2110

[richardlau]

I cant remember if @sam-github added the label to node-test-commit-aix or not

I don't think that has been done as otherwise builds would be running on the AIX 7.1 machines now.

also does anyType cover both test and release or just test?

It covers both. Or more technically it covers any setting of buildType:

build/jenkins/scripts/VersionSelectorScript.groovy

Lines 4 to 5 in 6bcc28e

	def releaseType = { buildType -> buildType == 'release' }
	def anyType = { buildType -> true }

[AshCripps]

I don't think that has been done as otherwise builds would be running on the AIX 7.1 machines now.

Yeah I checked our internal checklist and it was the next step for him to do.

It covers both. Or more technically it covers any setting of buildType:

Thought so.

[richardlau]

also does anyType cover both test and release or just test?

It covers both. Or more technically it covers any setting of buildType:

Thought so.

Furthermore currently the only type checked is releaseType (buildType is release). @joaocgreis is planning some changes (#2084 (comment)) that will also add a testType if we want to have different rules for test only.

[sam-github]

I think we also need to add a line to exclude RELEASE from aix71 for lt(15) (everything). Then, once the aix71-ppc64 label is added to node-test-commit-aix (which I haven't done yet, I'll do after this lands), tests will start to run on master, but releases won't run anywhere. As testing goes green on a branch, we extend the test support down to eventually include 10.x. In parallel, but slightly behind test coverage, and much more slowly (release-by-release), we'll start converting release builds to occur on AIX7.1.

[sam-github]

@AshCripps I think you might not have noticed:

I think we also need to add a line to exclude RELEASE from aix71 for lt(15) (everything)

[richardlau]

@AshCripps I think you might not have noticed:

I think we also need to add a line to exclude RELEASE from aix71 for lt(15) (everything)

We don't want to build 14 on AIX 7.1?

[sam-github]

@richardlau yes, we want to, but we do this in order, usually:

for each V in (14, 13, 12, 10)
  enable test builds for V on NEW MACHINE
  wait for tests to be green
  stop release builds on OLD MACHINE
  start release builds on NEW MACHINE
  // setup in .groovy must ensure that ONLY one machine gets selected to do release builds on a V
  wait for no reports of problems for users of releases build on NEW MACHINE
end

I don't know, I guess we cloud start doing testing and releases on the 7.1 machines for all release lines > = 10 immediately, but we're generally more cautious.

I pushed a fixup commit.

@richardlau LGTY with above context? I could add the aix61 build label to node-test-commit-aix as soon as this lands.

[richardlau]

SGTM. Thanks for the context.

[AshCripps]

@AshCripps I think you might not have noticed:

I think we also need to add a line to exclude RELEASE from aix71 for lt(15) (everything)

Sorry @rsam completely blanked that thanks for the catch!