Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: use AIX7.1 for 13.x and 14.x #2111

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Conversation

AshCripps
Copy link
Member

v14 testing is looking green so this pr will enable testing on v13.

Ive also included changes to allow for releasing 14 from 7.1. LMT if anyone feels this is too soon/incorrect.

refs: #2110

Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would okay stopping testing on AIX 6.1 for Node.js 14 as things look good on 7.1.

@sam-github
Copy link
Contributor

I'd change the commit message to be more generic and enumerate the changes in the description, since it only describes one thing that the commit does, and add exclusion of aix61 for gt 13. Or maybe one commit for each change since they are so independent:

  • 13.x test with 7.1
  • 14.x release with 7.1
  • 14.x exclude test with 6.1

@AshCripps
Copy link
Member Author

Ive split the commits up, PTAL.

@AshCripps AshCripps force-pushed the aix71-13.x branch 2 times, most recently from 75162fc to 5ff5649 Compare December 30, 2019 16:26
13.x still releases on 6.1, 14.x only releases on 7.1.
Testing for 13.x is on 7.1 and 6.1
@sam-github sam-github changed the title jenkins: enable AIX7.1 testing on v13 jenkins: use AIX7.1 for 13.x and 14.x Dec 30, 2019
@AshCripps AshCripps merged commit 552c2c1 into nodejs:master Dec 30, 2019
@sam-github
Copy link
Contributor

AshCripps pushed a commit to AshCripps/build that referenced this pull request Dec 30, 2019
AshCripps pushed a commit to AshCripps/build that referenced this pull request Dec 30, 2019
AshCripps pushed a commit that referenced this pull request Dec 30, 2019
@AshCripps AshCripps deleted the aix71-13.x branch January 8, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants