jenkins: use ccache with devtoolset on ppc64le #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because devtoolset setup works by putting the devtoolset bin/ on the front of PATH the compiler is called directly instead of via the ccache wrappers. Change select-compiler.sh to explicitly use ccache, as it does for s390x.
sam-github
approved these changes
Feb 5, 2020
AshCripps
approved these changes
Feb 5, 2020
|
nodejs/node#31628 is now on the staging branches of all supported release lines so merging. |
rvagg
pushed a commit
that referenced
this pull request
Mar 4, 2020
Because devtoolset setup works by putting the devtoolset bin/ on the front of PATH the compiler is called directly instead of via the ccache wrappers. Change select-compiler.sh to explicitly use ccache, as it does for s390x. Co-authored-by: Sam Roberts <vieuxtech@gmail.com>
|
Looks like it's working 🎉. Test builds (of current nodejs/master): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands the first commit from #1927 for
centos7-ppcleto reenable ccache. The other commit is not required as onppcle-ubuntu1404we useccachevia the symbolic links in/usr/lib/ccache.This is blocked on nodejs/node#31628 landing on all supported release lines to avoid breaking https://ci.nodejs.org/job/node-test-commit-v8-linux/.
Refs: nodejs/node#31628
Refs: #1940
cc @nodejs/platform-ppc