doc: add sam-github to release admins #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshCripps
approved these changes
Apr 3, 2020
rvagg
reviewed
Apr 6, 2020
README.md
Outdated
| @@ -305,4 +308,5 @@ are required. After that the configuration will be removed. | |||
| [node]: https://nodejs.org/ | |||
| [ns]: https://nodesource.com/ | |||
| [pivotal]: https://www.pivotalagency.com.au/ | |||
| [release secrets]: https://github.com/nodejs-private/secrets/tree/master/build/release/.gpg | |||
There was a problem hiding this comment.
Its intentional - the .gpg directory contains the list of people with access
sam-github
commented
Apr 6, 2020
README.md
Outdated
| @@ -305,4 +308,5 @@ are required. After that the configuration will be removed. | |||
| [node]: https://nodejs.org/ | |||
| [ns]: https://nodesource.com/ | |||
| [pivotal]: https://www.pivotalagency.com.au/ | |||
| [release secrets]: https://github.com/nodejs-private/secrets/tree/master/build/release/.gpg | |||
There was a problem hiding this comment.
Suggested change
| [release secrets]: https://github.com/nodejs-private/secrets/tree/master/build/release/.gpg | |
| [release secret members]: https://github.com/nodejs-private/secrets/tree/master/build/release/.gpg |
^--- maybe make that its a link to the membership list more explicit? Generally, we link to the gh team with access, so the list in the README.md can be audited against the actual membership, and the .gpg directory is the equivalent for this group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2220