Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: fix scripts for LinuxONE and SmartOS #2569

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

richardlau
Copy link
Member

Move non-package manager ccache tasks into partial tasks to
avoid the different platforms interfering which each other.

Fixes: #2533

This refactors by replacing ansible/roles/baselayout/tasks/ccache.yml and
platform specific ccache tasks in ansible/roles/baselayout/tasks/main.yml
with platform specific versions under ansible/roles/baselayout/tasks/partials/ccache.

Move non-package manager ccache tasks into partial tasks to
avoid the different platforms interfering which each other.
@richardlau
Copy link
Member Author

One thing I've not changed is the version of ccache being installed, which on AIX, LinuxONE and SmartOS is not the latest (3.7.2 on AIX and 3.6 on LinuxONE and SmartOS).

The replaced ansible/roles/baselayout/tasks/ccache.yml was downloading ccache source from https://www.samba.org/ftp/ccache/ but ccache stopped uploading to there after ccache 3.6: https://lists.samba.org/archive/ccache/2019q2/001580.html

I'd prefer to look at that separately in a follow up PR if necessary.

@richardlau richardlau merged commit f65a7e6 into nodejs:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"baselayout : run ccache installer" fails running ansible against LinuxONE/smartos
2 participants