Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible,jenkins: add OpenSSL 3.0.0 to sharedlibs container #2601

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

richardlau
Copy link
Member

Add OpenSSL 3.0.0 alpha13 to the sharedlibs container. Add an entry to
the VersionSelectorScript to build against it with Node.js 15 onwards.

Update OpenSSL 1.1.1g to 1.1.1k.

Refs: #2584

Add OpenSSL 3.0.0 alpha13 to the sharedlibs container. Add an entry to
the VersionSelectorScript to build against it with Node.js 15 onwards.

Update OpenSSL 1.1.1g to 1.1.1k.
@richardlau
Copy link
Member Author

richardlau commented Mar 31, 2021

I've ansibled these changes on test-softlayer-ubuntu1804_docker-x64-1 and restarted the sharedlibs containers on it.
I'm currently unable to edit/save https://ci.nodejs.org/job/node-test-commit-linux-containered or a copy of it (#2602) which means I've not been able to test these changes on the CI.

@richardlau
Copy link
Member Author

Forgot to state, the plan would be (when I can edit the job) to add the ubuntu1804_sharedlibs_openssl300_x64 label to the CI job and a condition step for it based on the existing ubuntu1804_sharedlibs_openssl111_x64 one but pointing at the OpenSSL 3.0.0 env var and directories.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 I've been meaning to get around to that 1.1.1 bump too, so thanks for adding that in!

@richardlau
Copy link
Member Author

richardlau commented Apr 1, 2021

Reansibled the two digitalocean docker hosts, restarted the sharedlibs containers, and added the ubuntu1804_sharedlibs_openssl300_x64 label to them:
image

Still looking into the job edit/save issue.

@richardlau
Copy link
Member Author

@richardlau richardlau merged commit 371bb76 into nodejs:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible ci-change PSA of configuration changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants