Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,test: Add CentOS7 Dockerfile (arm64 only for now) #2738

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

sxa
Copy link
Member

@sxa sxa commented Aug 31, 2021

"arm64 only" is due to the special way that I'm currently installing the devtoolset-6 packages in here for now. I feel this needs a better solution ...

Signed-off-by: Stewart X Addison sxa@redhat.com

Signed-off-by: Stewart X Addison <sxa@redhat.com>
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as this documents the current install even if we are going to change in the future.

@sxa sxa merged commit a655f1a into nodejs:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants