Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: add ICU 71 to sharedlibs images #2934

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Conversation

targos
Copy link
Member

@targos targos commented Apr 26, 2022

@richardlau
Copy link
Member

Just tried to rebuild the containers with this applied and they're failing to build for an unrelated reason --

curl -sL https://zlib.net/zlib-1.2.11.tar.gz | tar zxv --strip=1 && \
is failing because https://zlib.net/zlib-1.2.11.tar.gz no longer exists. I'm guessing it was removed after the recent zlib CVE. I'll add a commit here to bump to zlib 1.2.12 and try again.

The referenced zlib 1.2.11 tarball no longer exists. Update to
1.2.12. Contains a refactor so we only have to update the version
in one place in the future.
@richardlau
Copy link
Member

@richardlau
Copy link
Member

The Jenkins job had the expected zlib version hardcoded:
https://ci.nodejs.org/job/node-test-commit-linux-containered/31647/nodes=ubuntu1804_sharedlibs_zlib_x64/console

18:29:22 ++ out/Release/node -pe process.versions
18:29:22 ++ grep zlib
18:29:22 + ZLIB_VERSION='  zlib: '\''1.2.12'\'','
18:29:22 + echo 'zlib Version:   zlib: '\''1.2.12'\'','
18:29:22 zlib Version:   zlib: '1.2.12',
18:29:22 ++ echo zlib: ''\''1.2.12'\'','
18:29:22 ++ grep 1.2.11
18:29:22 + '[' X = X ']'
18:29:22 + FAIL_MSG='Not built with zlib 1.2.11, exiting'
18:29:22 + echo Not built with zlib 1.2.11, exiting
18:29:22 Not built with zlib 1.2.11, exiting
18:29:22 + echo 1..1
18:29:22 + echo 'not ok 1 Not built with zlib 1.2.11, exiting'
18:29:22 + exit -1

I've updated the job to expect 1.2.12.

New test build: https://ci.nodejs.org/job/node-test-commit-linux-containered/31648/

@targos
Copy link
Member Author

targos commented Apr 28, 2022

New build is green.

@richardlau richardlau merged commit b2d4017 into master Apr 28, 2022
@richardlau richardlau deleted the icu-71-sharedlibs branch April 28, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants