Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecation errors in macos 10.x #3130

Merged
merged 5 commits into from
Dec 21, 2022
Merged

fix: deprecation errors in macos 10.x #3130

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
539c38b
fix: deprecation errors in macos 10.x
UlisesGascon Dec 20, 2022
1ea3173
chore: refactor task logic to use mac10
UlisesGascon Dec 20, 2022
4c3e581
fix: typo in ansible syntaxis
UlisesGascon Dec 20, 2022
0d7a28a
chore: simplified step
UlisesGascon Dec 20, 2022
68c8489
fix: logic typo
UlisesGascon Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ansible/roles/package-upgrade/tasks/partials/brew.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,12 @@
script: files/install-homebrew.sh
when: os == "macos11.0" and not armbrew.stat.exists

- name: Upgrade installed packages
# Ignoring deprecation errors in MacOS 10.x
- name: Upgrade installed packages
UlisesGascon marked this conversation as resolved.
Show resolved Hide resolved
become_user: "{{ ansible_user }}"
homebrew:
upgrade_all: yes
ignore_errors: os == "macos10.15" or os == "macos10.14"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ansible tells me that the value is invalid:

TASK [package-upgrade : Upgrade installed packages] ******************************************************************** fatal: [release-nearform-macos11.0-arm64-1]: FAILED! => {"msg": "the field 'ignore_errors' has an invalid value (os == \"macos10.15\" or os == \"macos10.14\"), and could not be converted to an bool.The error was: The value 'os == \"macos10.15\" or os == \"macos10.14\"' is not a valid boolean. Valid booleans include: 'true', 1, 0, 'no', 'false', 'yes', 'n', 'y', '0', 'on', '1', 'off', 't', 'f'\n\nThe error appears to be in '/home/mzasso/git/nodejs/build/ansible/roles/package-upgrade/tasks/partials/brew.yml': line 40, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n # Ignoring deprecation errors in MacOS 10.x\n - name: Upgrade installed packages\n ^ here\n"} ...ignoring

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what version are you using? 🤔

Copy link
Member

@targos targos Feb 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ansible [core 2.14.2]
ansible python module location = /opt/homebrew/Cellar/ansible/7.2.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does

Suggested change
ignore_errors: os == "macos10.15" or os == "macos10.14"
ignore_errors: "{{ os == 'macos10.15' or os == 'macos10.14' }}"

work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should skip the step instead of ignoring errors. It takes ages to run because Homebrew doesn't support macOS <11 and it has to compile packages from source.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should skip the step instead of ignoring errors. It takes ages to run because Homebrew doesn't support macOS <11 and it has to compile packages from source.

The Ansible scripts are supposed to be able to both:

  • Set up a new VM/machine from scratch.
  • Update an existing VM/machine.

For Orka we could possibly get away with the first by relying on snapshots, but it wouldn't help for the Nearform VMs (I guess we could snapshot those but we'd have to find storage for the snapshots and we already have disk space issues on those machines).

I would suggest though that we plan to move off macOS 10.15, at least for Node.js 20 and beyond.


- name: Install brew cu
become_user: "{{ ansible_user }}"
Expand Down