chore(404): no cache for 404

[ovflowd]

This PR adds no-cache for 404 pages

[MoLow]

LGTM

[richardlau]

@ovflowd

# nginx -t
nginx: [emerg] invalid number of arguments in "try_files" directive in /etc/nginx/sites-enabled/00-nodejs.org:39
nginx: configuration file /etc/nginx/nginx.conf test failed

[ovflowd]

Yeah, that makes sense. It was a bet, let me change that.

[ovflowd]

@richardlau done.

[richardlau]

# nginx -t
nginx: the configuration file /etc/nginx/nginx.conf syntax is ok
nginx: configuration file /etc/nginx/nginx.conf test is successful

🎉

Going to deploy 🤞 .

[ovflowd]

@richardlau I've just made an update using alias as @targos suggested, not sure which option is better tbh

[richardlau]

With the alias

# nginx -t
nginx: [emerg] the "alias" directive cannot be used inside the named location in /etc/nginx/sites-enabled/00-nodejs.org:39
nginx: configuration file /etc/nginx/nginx.conf test failed

[targos]

Let's keep it without the alias, then.

[ovflowd]

Wait, if the real path is /en/404/index.html ... shouldn't that actually be causing problems? How is it able to find /en/404.html?

[richardlau]

Making sure this doesn't land with the alias (failing nginx -t).

[richardlau]

nginix is still unhappy:

# nginx -t
nginx: [emerg] the "alias" directive cannot be used inside the named location in /etc/nginx/sites-enabled/00-nodejs.org:39
nginx: configuration file /etc/nginx/nginx.conf test failed

[ovflowd]

Yeah, alias cannot be used within named locations. That makes sense.

[richardlau]

# nginx -t
nginx: the configuration file /etc/nginx/nginx.conf syntax is ok
nginx: configuration file /etc/nginx/nginx.conf test is successful

🎉

[ovflowd]

@richardlau this needs to get merged first nodejs/nodejs.org#5155

(If you apply the nginx config now next.js default 404 is gone, meaning /404.html doesn't exist anymore)

[ovflowd]

I've just merged the PR on nodejs/nodejs.org. (@richardlau). Let's wait for the build to finish within the server 👀

[targos]

c7ab832 is now deployed