added benchmarking.nodejs.org setup to www #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ssh keypair is in secrets/build/infra/benchmark_id_rsa & secrets/build/infra/benchmark_id_rsa.pub |
rvagg
force-pushed
the
benchmark-sync
branch
from
182950e to
8d3537e
Compare
|
Sounds good to me. |
|
Can this be closed now ? |
| @@ -41,6 +42,7 @@ | |||
| - '* * * * * nodejs /home/nodejs/check-build-site.sh nodejs' | |||
| - '* * * * * nodejs /home/nodejs/check-build-site.sh iojs' | |||
| - '* * * * * root /home/nodejs/cdn-purge.sh' | |||
| - '* */4 * * * nodejs rsync -avz --delete benchmark:charts/ /home/www/benchmarking/charts/' | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Added some nitpick! LGTM regardless. |
|
I assume this should still be landed. @rvagg can you address @jbergstroem comments and then I'll land ? |
|
done and merged, need to fix up my other www PR now that I've discovered this one .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #281
this is live on the site now