jenkins: improve x64 node.exe caching for arm64 #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanStojanovic
force-pushed
the
mefi-x64-node-cache-fix
branch
from
80eaa17 to
0300809
Compare
|
Can someone from @nodejs/build review please? After landing this, the same code will be added to the release CI since not having caching there caused machines to be stuck on ARM64 builds indefinitely until manual action is taken to unblock it. |
richardlau
approved these changes
Oct 17, 2023
StefanStojanovic
added a commit
to JaneaSystems/build
that referenced
this pull request
Oct 19, 2023
This reverts commit 646ff04. The change being reverted broke basic sanity check in the node-compile-windows-debug job in test CI.
richardlau
pushed a commit
that referenced
this pull request
Oct 19, 2023
StefanStojanovic
added a commit
to JaneaSystems/build
that referenced
this pull request
Jul 26, 2024
Fixes: nodejs#3504 Refs: nodejs#3315 Refs: nodejs#3514 Refs: nodejs#3533
StefanStojanovic
added a commit
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noticed on a few occasions that x64 node.exe caching is error-prone. This happens due to issues with downloading the new node.exe which, if it goes bad, makes the machine unusable for arm64 compilation for a week. This improvement in caching logic removes that possibility, by validating the downloaded file's SHASUM and replacing the old one with it, only if it matches the SHASUM found in the official
SHASUMS256.txtfile.Fixes: #3504
Refs: #3315