Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jenkins: stop building on 32-bit Windows for Node.js 23 #3743

Merged
merged 1 commit into from
May 29, 2024
Merged

jenkins: stop building on 32-bit Windows for Node.js 23 #3743

merged 1 commit into from
May 29, 2024

Conversation

targos
Copy link
Member

@targos targos commented May 28, 2024

UlisesGascon
UlisesGascon approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

StefanStojanovic
StefanStojanovic approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great, we'll be able to compile up to 3 PRs in CI simultaneously now!

@targos targos merged commit d578923 into nodejs:main May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@richardlau richardlau richardlau approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
platform:windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @UlisesGascon @richardlau @StefanStojanovic