github-bot: ansible setup #469
Conversation
| WantedBy=multi-user.target | ||
|
|
||
| [Service] | ||
| ExecStart=/usr/bin/npm start |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Thanks for excellent reviews, just what I needed! |
|
You accidentally checked in |
| apt: name="{{ item }}" state=latest | ||
| with_items: "{{ baseline_packages }}" | ||
| tags: general | ||
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Just pushed a commit removing some unwanted quotes. I thought every variable should be quoted, that didn't work as expected. Tried this playbook on the server running the bot in production ATM, but couldn't get the bot started afterwards. Suddenly realised a strange directory had been made in /home# ls
drwxr-xr-x 4 iojs root 4096 Aug 25 13:41 "iojs"
drwxr-xr-x 5 iojs iojs 4096 Aug 25 13:47 iojs |
|
@phillipj you should quote the full string, not the variable. That way it doesn't get escaped. |
|
Ok, if you've tested that quotes work this is LGTM. Thanks for enduring my nitpick :) Great to have you on board! |
|
My pleasure, now I almost know how ansible works and your nitpicks was perfect for doing things right™. I'll squash 14 commits so far, but let you decide when the time is right to merge -- maybe land your big ansible refactoring first for all I know. |
This adds an ansible setup for the github-bot. Primarly installs necessary binaries, checks out the application code from github.com, before starting the systemd service. Refs: nodejs#404 PR-URL: nodejs#469 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
Squash it and see if anyone else in the build group wants to LGTM, then merge at will! |
phillipj
force-pushed
the
ansible-github-bot
branch
from
cea8a89
to
918ceca
Compare
|
LGTM |
Sooo, here's my first shot at creating an ansible setup for the bot. Has been run on the test host @jbergstroem created for this purpose, seems to be working nicely.
Primarly installs necessary binaries, checks out the application code from github.com, before starting the created systemd service which runs (and supervises)
npm start.As there's a big ansible refactor just around the corner, these changes doesn't need to be merged asap, but would be nice to get some feedback about obviously missing/wrong parts.