-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow commit message ONLY with --messageonly #156
Conversation
test.js
Outdated
* refactor and improve | ||
test: | ||
* update refs for testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* refactor and improve | |
test: | |
* update refs for testing | |
* refactor and improve | |
test: | |
* update refs for testing |
lgtm, there's a test failure with a simple fix as I've suggested, also please remove the package-lock.json from the commit |
Apologies - forgot to check back on this - will take a look |
Think that should do it? Finding it hard to run the tests locally as I'm on Windows 11 - even using WSL (Ubuntu) the tests aren't passing properly all of the time. Use the output from the workflow to fix the tests - I hope. |
Yeah, sorry, windows support is lacking, there was an attempt to do it at one point but that was never completed. You're welcome to give that a try but iirc it was kind of gnarly. Some of that history can be traced through here: #66 |
commit-to-output.js
Outdated
let s = '' | ||
s += data.summary | ||
return ` * ${s.trim()}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let s = '' | |
s += data.summary | |
return ` * ${s.trim()}` | |
return ` * ${data.summary.trim()}` |
lgtm except for that one little change to remove unnecessary lines |
Lines removed. I know exactly what I did there - took the toStringPlaintext and removed the lines I didn't want - then didn't spot the shortcut :) If I can find time, I'll have a look at the Windows tests - I already had a branch open to look at it but ran out of time. |
excellent, thanks, I hope this is now more useful for you |
## [4.1.0](v4.0.1...v4.1.0) (2024-01-10) ### Features * allow commit message ONLY with --messageonly ([#156](#156)) ([e069500](e069500))
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
For my project we needed the commit messages only (with no URLs, author names etc). I added the functionality for my project and thought I'd submit it here too to see if it is useful for others. Follows the same pattern as
--plaintext
but displays the commit messages only.Also changed the grouping so that it doesn't display the single colon if the commitGroup value is undefined/empty.