Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #19 #20

Merged
merged 1 commit into from
Jul 17, 2015
Merged

fix #19 #20

merged 1 commit into from
Jul 17, 2015

Conversation

maboiteaspam
Copy link
Contributor

Restore original Markdown formatting.

@maboiteaspam
Copy link
Contributor Author

I m not really sure if i should go further in the release process ? And in that eventuality, how to proceed.

Anyway, they look really cool now

  • [23efb05cc3] - doc: document fs.watchFile behaviour on ENOENT (Brendan Ashworth) #2093
  • [1afc0c9e86] - fs: fix error on bad listener type (Brendan Ashworth) #2093

Too bad I dropped that error into the source.

@rvagg
Copy link
Member

rvagg commented Jul 17, 2015

lgtm, just stop short of bumping version and publishing, I'll hang on to that responsibility for now

@maboiteaspam
Copy link
Contributor Author

sure.

I m buggy about the last comment made by some guys on iojs project, about the missing commits.

Should i just checkout io project and run the command then check the commits listed to figure out ?

@rvagg
Copy link
Member

rvagg commented Jul 17, 2015

Yeah, missing commits, ignore that for now, it's not relevant for this but it is an interesting problem that I'd love to find a solution to.

Basically if you have multiple branches and tag on them, like this:

branch1 ----- a ----- c -------------------------

branch2 --- b ------------- d -------------------

and you want to do a changelog-maker on branch1 from tag c to the current HEAD you will only get commits from the time of tag d onwards even though it's on a completely different branch. This is because we just look at the list of tags, regardless of which branch they are on and use the time of the latest tag as our starting point.

It's solvable now by using changelog-maker --start-ref=c, but as we do more multi-branch releases in io.js this is increasingly becoming a problem.

So we need a way to list tags on the current branch only, ignoring other branches.

@maboiteaspam
Copy link
Contributor Author

OK, thanks a lot for explanations ! I ll try to figure out about it.

@rvagg
Copy link
Member

rvagg commented Jul 17, 2015

happy for you to merge this btw then I can cut a new relesae

maboiteaspam added a commit that referenced this pull request Jul 17, 2015
Restore original Markdown formatting
Fix #19
@maboiteaspam maboiteaspam merged commit 74eac58 into nodejs:master Jul 17, 2015
@maboiteaspam maboiteaspam deleted the fix-19 branch July 23, 2015 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants