Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref is failing with 8.3.0 #464

Closed
al-k21 opened this issue Aug 22, 2017 · 5 comments
Closed

ref is failing with 8.3.0 #464

al-k21 opened this issue Aug 22, 2017 · 5 comments

Comments

@al-k21
Copy link
Contributor

al-k21 commented Aug 22, 2017 

error:                 | 132 passing (176ms)                                                                                                                                         
error:                 | 2 failing                                                                                                                                                   
error:                 |                                                                                                                                                             
error:                 | 1) Object should retain references to written Objects:                                                                                                      
error:                 |                                                                                                                                                             
error:                 | AssertionError [ERR_ASSERTION]: "o" has not been garbage collected                                                                                          
error:                 | + expected - actual                                                                                                                                         
error:                 |                                                                                                                                                             
error:                 | -false                                                                                                                                                      
error:                 | +true                                                                                                                                                       
error:                 |                                                                                                                                                             
error:                 | at Context.<anonymous> (test/object.js:46:5)                                                                                                                
error:                 |                                                                                                                                                             
error:                 | 2) pointer should retain references to a written pointer in a Buffer:                                                                                       
error:                 |                                                                                                                                                             
error:                 | AssertionError [ERR_ASSERTION]: "child" has not been garbage collected                                                                                      
error:                 | + expected - actual                                                                                                                                         
error:                 |                                                                                                                                                             
error:                 | -false                                                                                                                                                      
error:                 | +true                                                                                                                                                       
error:                 |                                                                                                                                                             
error:                 | at Context.<anonymous> (test/pointer.js:45:5)
  • Node Version: 8.3.0 (does not fail on 8.2.1)
  • Citgm version: 2.0.5
  • Platform: Darwin
@al-k21
Copy link
Contributor Author

al-k21 commented Aug 29, 2017

@TooTallNate do you know why is it failing ?

@targos
Copy link
Member

targos commented Aug 29, 2017

This is likely due to the V8 upgrade. We have to investigate if this is a bug in the garbage collector or a wrong assumption from the test.

targos added a commit to targos/ref that referenced this issue Aug 29, 2017
@targos
test: fix tests after V8 6.0 GC changes
e1fe604 
Ref: nodejs/citgm#464
@targos targos mentioned this issue Aug 29, 2017
Merged
@targos
Copy link
Member

targos commented Aug 29, 2017

Attempt to fix the tests: TooTallNate/ref#85

@targos
Copy link
Member

targos commented Aug 29, 2017

This should be fixed with ref v1.3.5.

@gdams
Copy link
Member

gdams commented Aug 30, 2017

confirmed fixed for me

@gdams gdams closed this as completed Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@targos @gdams @al-k21