Travis CI currently broken

[richardlau]

Travis CI runs on master and recent PRs have test failures.

e.g. https://travis-ci.com/nodejs/citgm/branches

Build #253:
https://travis-ci.com/nodejs/citgm/jobs/174170189#L462-L496

> citgm@3.4.8 tap /home/travis/build/nodejs/citgm
> tap -J --timeout 240 "test/**/test-*.js" "--coverage" "--coverage-report=lcov"
/home/travis/build/nodejs/citgm/lib/package-manager/test.js:1
ReferenceError: _ad4‍ is not defined
    at Function.__get__ (/home/travis/build/nodejs/citgm/lib/package-manager/test.js:8:21)
    at Object.<anonymous> (/home/travis/build/nodejs/citgm/test/npm/test-npm-author-name.js:8:28)
    at Generator.next (<anonymous>)
/home/travis/build/nodejs/citgm/lib/lookup.js:31
// Pull the repository url either from the lookup table
                    ^
/home/travis/build/nodejs/citgm/lib/lookup.js:1
ReferenceError: _ad4‍ is not defined
    at Function.__get__ (/home/travis/build/nodejs/citgm/lib/lookup.js:31:21)
    at Object.<anonymous> (/home/travis/build/nodejs/citgm/test/test-lookup.js:8:24)
    at Generator.next (<anonymous>)
test/bin/test-citgm-all.js .......................... 18/18 2m
test/bin/test-citgm.js ................................ 8/8 44s
test/npm/test-npm-author-name.js ...................... 0/1
  not ok test/npm/test-npm-author-name.js
    timeout: 240000
    file: test/npm/test-npm-author-name.js
    childId: 2
    command: /home/travis/.nvm/versions/node/v11.8.0/bin/node
    args:
      - '-r'
      - /home/travis/build/nodejs/citgm/node_modules/esm/esm.js
      - test/npm/test-npm-author-name.js
    stdio:
      - 0
      - pipe
      - 2
    cwd: /home/travis/build/nodejs/citgm
    exitCode: 1

[richardlau]

This looks like it's related to rewire:

• ReferenceError: _ff9‍ is not defined jhnns/rewire#158
• v ^12.5.0 produces error when calling rewire module.__set__ tapjs/tapjs#509

[richardlau]

Okay it looks like it's tap. If I manually rollback to tap@12.4.1 then our tests run cleanly (but fail just like the CI with tap@12.5.2).

[richardlau]

New version of esm has been released to fix the problem: tapjs/tapjs#509 (comment)

Requested a CI run on master: https://travis-ci.com/nodejs/citgm/builds/101177628

[richardlau]

Well the good news is the original failures appear fixed.

Bad news is we have a test failure (test-npm-install.js) on Node.js 11.10.0 (which comes with a new npm): https://travis-ci.com/nodejs/citgm/jobs/178283173#L468-L869

[richardlau]

Moved the failure with Node.js 11.10.0 over to #680.