Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-npm-install.js fails with Node.js 11.10.0 #680

Closed
richardlau opened this issue Feb 16, 2019 · 2 comments
Closed

test-npm-install.js fails with Node.js 11.10.0 #680

richardlau opened this issue Feb 16, 2019 · 2 comments

Comments

@richardlau
Copy link
Member

From #679 (comment):
We have a test failure (test-npm-install.js) on Node.js 11.10.0 (which comes with a new npm): https://travis-ci.com/nodejs/citgm/jobs/178283173#L468-L869

@richardlau
Copy link
Member Author

So this is similar to #577. In Node.js 11.10.0 npm has been updated and npm has had an internal rewrite that has resulted in the message changing again.

For reference:
On npm 3.10.10 (Node.js 6):

npm ERR! code E404

npm ERR! 404 Not found : THIS-WILL-FAIL
npm ERR! 404
npm ERR! 404  'THIS-WILL-FAIL' is not in the npm registry.
npm ERR! 404 Your package name is not valid, because
npm ERR! 404  1. name can no longer contain capital letters
npm ERR! 404 It was specified as a dependency of 'omg-bad-tree'
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm 6.4.1 (Node.js 8 and 10):

npm ERR! code E404
npm ERR! 404 Not Found: THIS-WILL-FAIL@0.0.1

npm 6.7.0 (Node.js 11.10.0):

npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/THIS-WILL-FAIL - Not found
npm ERR! 404
npm ERR! 404  'THIS-WILL-FAIL@0.0.1' is not in the npm registry.
npm ERR! 404 Your package name is not valid, because
npm ERR! 404  1. name can only contain URL-friendly characters
npm ERR! 404  2. name can no longer contain capital letters
npm ERR! 404 It was specified as a dependency of 'omg-bad-tree'
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

testError: /npm ERR! 404 Not [Ff]ound\s*: THIS-WILL-FAIL(@0\.0\.1)?/

richardlau added a commit to richardlau/citgm that referenced this issue Feb 16, 2019
The checked error message differs between the version of npm included
in Node.js 11.10.0 compared to previous versions.

Fixes: nodejs#680
@richardlau
Copy link
Member Author

Proposed fix in #681.

BridgeAR pushed a commit that referenced this issue Feb 16, 2019
The checked error message differs between the version of npm included
in Node.js 11.10.0 compared to previous versions.

Fixes: #680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant