lib: drop skipped modules #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
This module isn't being tested in our CITGM for one of the following reasons: * "skip" is true - meaning we're skipping it into CITGM run * ">= EOL version" - meaning this module is being skipped in all active release lines
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
==========================================
+ Coverage 95.23% 96.33% +1.10%
==========================================
Files 28 28
Lines 2181 2181
==========================================
+ Hits 2077 2101 +24
+ Misses 104 80 -24 ☔ View full report in Codecov by Sentry. |
ljharb
reviewed
Dec 12, 2023
mcollina
reviewed
Dec 12, 2023
aduh95
approved these changes
Dec 12, 2023
anonrig
approved these changes
Dec 12, 2023
GeoffreyBooth
approved these changes
Dec 12, 2023
This was referenced Dec 14, 2023
|
Now I'm pinging module authors to inform them that the modules are being removed from If you believe your module isn't flaky anymore and should be included in the CITGM for all active release lines, please open a PR I'll be happy to review/approve it. @devinivy @DavidTPate @AdriVanHoudt Again, no action other than removing the modules should be made in this PR. I'm planning to merge it tomorrow. |
UlisesGascon
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on the recent bankruptcy of the CITGM, this PR removes all modules that are being skipped by either having a "skip: true" or because we're skipping all active release lines, for instance: ">= 17" or ">= 16". I know that the idea of "skip: true" was temporary, but some modules have been skipped for quite some time.
My suggestion for the modules that still want to be included in the current CITGM is to open a new PR to add it back so we guarantee our CITGM will not be red/failing until issues are fixed - please note a flaky CITGM affects directly the efforts of a release.
Before pinging module authors I'd like to get @nodejs/tsc approval since the list is big and I don't want to cause any more noise in their notification box.