Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: mark david as flaky on win32 #365

Closed
wants to merge 1 commit into from
Closed

Conversation

gdams
Copy link
Member

@gdams gdams commented Feb 24, 2017

David is failing on windows:

C:\Users\jenkins\workspace\SVT-V6-COMMUNITY-CITGM\ARCH\x64\GCC\gcc48\OS\win7\TAG\svt\tmp\3e38cc3b-ceb3-46ea-a311-0b9b1a189dc2\david\node_modules\.bin\tape.CMD:1
 (function (exports, require, module, __filename, __dirname) { @IF EXIST "%~dp0\node.exe" (
                                                               ^
 SyntaxError: Invalid or unexpected token
     at Object.exports.runInThisContext (vm.js:76:16)
     at Module._compile (module.js:542:28)
     at Object.Module._extensions..js (module.js:579:10)
     at Object.Module._extensions.(anonymous function) [as .js] (C:\Users\jenkins\workspace\SVT-V6-COMMUNITY-CITGM\ARCH\x64\GCC\gcc48\OS\win7\TAG\svt\tmp\3e38cc3b-ceb3-46ea-a311-0b9b1a189dc2\david\node_modules\istanbul\lib\hook.js:109:37)
     at Module.load (module.js:487:32)
     at tryModuleLoad (module.js:446:12)
     at Function.Module._load (module.js:438:3)
     at Function.Module.runMain (module.js:604:10)
     at runFn (C:\Users\jenkins\workspace\SVT-V6-COMMUNITY-CITGM\ARCH\x64\GCC\gcc48\OS\win7\TAG\svt\tmp\3e38cc3b-ceb3-46ea-a311-0b9b1a189dc2\david\node_modules\istanbul\lib\command\common\run-with-cover.js:122:16)
     at C:\Users\jenkins\workspace\SVT-V6-COMMUNITY-CITGM\ARCH\x64\GCC\gcc48\OS\win7\TAG\svt\tmp\3e38cc3b-ceb3-46ea-a311-0b9b1a189dc2\david\node_modules\istanbul\lib\command\common\run-with-cover.js:251:17
Checklist
  • npm test passes
  • contribution guidelines followed here
  • commit message follows commit guidelines

@gdams
Copy link
Member Author

gdams commented Feb 24, 2017

CC @alanshaw

@alanshaw
Copy link

alanshaw commented Feb 24, 2017

?? what does it mean to be flaky?

@gdams
Copy link
Member Author

gdams commented Feb 24, 2017

We can mark the module as flaky meaning that we expect the module to fail on a certain platform but I wanted to check with you if david was meant to work with windows

@alanshaw
Copy link

Is it actually this issue that we're coming up against: gotwarlost/istanbul#90

I'm happy to change the test command if it'll help. David is supposed to work on windows but the tests are rarely run on windows.

@gdams
Copy link
Member Author

gdams commented Feb 24, 2017

Looks like the same issue to me! It would be good to get david working on windows because then we can pick up new failures for you when they occur

alanshaw added a commit to alanshaw/david that referenced this pull request Feb 24, 2017
@alanshaw
Copy link

Ok that's done, hope that makes it not flaky :)

@gdams
Copy link
Member Author

gdams commented Feb 24, 2017

@alanshaw fixed! thanks for the speedy response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants