-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lookup: mark david as flaky on win32 #365
Conversation
CC @alanshaw |
?? what does it mean to be flaky? |
We can mark the module as flaky meaning that we expect the module to fail on a certain platform but I wanted to check with you if david was meant to work with windows |
Is it actually this issue that we're coming up against: gotwarlost/istanbul#90 I'm happy to change the test command if it'll help. David is supposed to work on windows but the tests are rarely run on windows. |
Looks like the same issue to me! It would be good to get david working on windows because then we can pick up new failures for you when they occur |
Ok that's done, hope that makes it not flaky :) |
@alanshaw fixed! thanks for the speedy response |
David is failing on windows:
Checklist
npm test
passes