-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lookup: add crc32-stream #430
Conversation
@ctalkington (re/ #429 (comment)), I've put you down as the maintainer of this module, so we'll ping you if we have any issues with it. Basically citgm does (not real code): VERSION=$(npm view crc32-stream | grep latest) # to get the version, e.g. 2.0.0
curl https://github.com/archiverjs/node-crc32-stream/archive/$VERSION.tar.gz | npm install
npm test What usually breaks us is people changing their Github tags from Also we run all the module tests in parallel, so using |
Nice! How about to adding node-archiver instead of crc32-stream btw...? |
I have no real opinion, @ctalkington what do you think? Maybe we should add both. |
this module is able to run on FIPS |
i say start with crc32-stream archiver mostly relies on other modules and i plan to make plugins register themselves in the future so if anything id test zip-stream or such down the road. |
CI 2: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/4/console Just to make sure it's all still working. |
Landed in feff5f5 |
CI was green, landing. |
@gibfahn I already landed it this morning |
@targos amazing, I'd have thought Github would have caught that (I merged with the Github UI). I'll push it off master again. EDIT: Removed commit. |
Fixes: #429
Checklist
npm test
passes (doesn't on master due to v8.0.0 — zlib.DeflateRaw only extensible via class keyword node#13358)citgm crc32-stream
using this lookup passes on my machine.