Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add --lkgr and --ulkgr options #552

Closed
wants to merge 4 commits into from
Closed

Conversation

al-k21
Copy link
Contributor

@al-k21 al-k21 commented Mar 2, 2018

Added:

  • lkgr to the lookup (modules that passed on my mac).
  • --lkgr option for citgm and citgm-all, which rans lkgr from the lookup, instead of defaulting to taking npm latest.
  • --ulkgr option for citgm and citgm-all, to update lookup

Let me know what you think and let's discuss if we want to include platforms flakiness for lkgr.

TODO:

  • Support for different platforms and node versions.
  • Error handling
  • Raise a PR
  • Tests
  • Documentation
Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • contribution guidelines followed here

Refs: #407

add upadate task that will only run when --ulkgr option passed
@al-k21 al-k21 requested review from MylesBorins and gibfahn March 2, 2018 13:43
@al-k21
Copy link
Contributor Author

al-k21 commented Jun 6, 2018

Closing, reopen if needed.

@al-k21 al-k21 closed this Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant