Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: re-add tough-cookie #981

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

lookup: re-add tough-cookie #981

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 24, 2023

Checklist
  • npm test passes
  • contribution guidelines followed
    here

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f15c9a2) 96.44% compared to head (95fb9c5) 96.44%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #981   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          28       28           
  Lines        2139     2139           
=======================================
  Hits         2063     2063           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@targos
Copy link
Member

targos commented Aug 4, 2024

@targos
Copy link
Member

targos commented Aug 5, 2024

@Trott
Copy link
Member Author

Trott commented Aug 5, 2024

Oh well, still failing. Back to draft mode.

@Trott Trott marked this pull request as draft August 5, 2024 17:44
@Trott
Copy link
Member Author

Trott commented Aug 5, 2024

Sample error:

 added 246 packages in 11s
 > tough-cookie@4.1.4 test
 > vows test/*_test.js && npm run eslint
                  
    
    
     util usage in Cookie 
        custom inspect for Cookie still works 
                 
         actual expected 
          
         Cookie="a=1; Domain=example.com; Path=/; hostOnly=?; aAge=?; cAge=1ms0ms" 
          // /home/iojs/tmp/citgm_tmp/a1c3705b-8fec-4e63-a472-a173b880f632/tough-cookie/node_modules/vows/lib/assert/macros.js:14 
    Broken  826 honored  1 broken (6.895s) 
   
 (node:2510650) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
 (Use `node --trace-deprecation ...` to show where the warning was created)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants