Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: fix entries for underscore, dicer, and csv-parser #986

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 26, 2023

Checklist
  • npm test passes
  • contribution guidelines followed
    here

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d51853b) 96.25% compared to head (60396b7) 96.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
+ Coverage   96.25%   96.44%   +0.18%     
==========================================
  Files          28       28              
  Lines        2139     2139              
==========================================
+ Hits         2059     2063       +4     
+ Misses         80       76       -4     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Trott
Copy link
Member Author

Trott commented Sep 26, 2023

@Trott Trott merged commit de43d87 into main Sep 27, 2023
8 checks passed
@Trott
Copy link
Member Author

Trott commented Sep 27, 2023

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3268/

The three modules affected by this PR now pass. Landing.

@Trott Trott deleted the fixes branch September 27, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants