feat: add initSync() to initialize WASM synchronously #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
commented
Aug 22, 2024
| @@ -1439,4 +1439,5 @@ function isExpressionTerminator (curPos) { | |||
| const initPromise = Promise.resolve(); | |||
|
|
|||
| module.exports.init = () => initPromise; | |||
| module.exports.initSync = () => {}; | |||
There was a problem hiding this comment.
I am not sure why dist/lexer.js was never documented in the README, despite being what Node.js core has been using. But anyway this is added to lexer.js for parity.
This uses the synchronous WebAssembly APIs to compile the WASM part synchronously, which allows users to initialize the library and parse synchronously with WASM without having to resort to the JS version. This would be useful for Node.js core to use the WASM version in paths that require synchronous initialization (it currently always uses the JS version for that).
joyeecheung
commented
Aug 22, 2024
guybedford
approved these changes
Aug 25, 2024
|
I'm not sure why CI has suddenly stopped triggering for this repo, but I tested locally and released this in 1.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the synchronous WebAssembly APIs to compile the WASM part synchronously, which allows users to initialize the library and parse synchronously with WASM without having to resort to the JS version. This would be useful for Node.js core to use the WASM version in paths that require synchronous initialization (it currently always uses the JS version for that).