Code And Learn at NodeFest 2017 #72

hiroppy · 2017-10-18T08:20:34Z

Hi!

We will hold NodeFest which is the largest Node.js conference in Japan.
I’m one of the organizers this year.
The team members are @yosuke-furukawa, @watilde, myself and some other great nodeschool staff.

We would like to open code-and-learn-jp on NodeFest and support the contribution to nodejs/core.

Please feel free to suggest any contribution areas for the participants! @nodejs/collaborators
We will receive some PRs on 26th November.(http://nodefest.jp/2017/schedule.html)

/cc @yosuke-furukawa @watilde @nodejs/nodejs-ja

Thanks.

Mentors

joyeecheung · 2017-10-18T08:32:51Z

cc @Trott @addaleax

Also, I will be there. Happy to help out with whatever needed.

ronkorving · 2017-10-18T08:40:50Z

Of course I will be there 👍

vsemozhetbyt · 2017-10-18T08:57:13Z

Possible case in tests: nodejs/node#16243 (comment) + next comment: check else if by if replacements when a previous if contains return. Also check else eliminations on similar condition.

hiroppy · 2017-10-18T13:59:32Z

@vsemozhetbyt Thank you for your information!

watilde · 2017-10-18T14:09:31Z

Note: Here is the last time we had - #58

jasnell · 2017-10-18T14:25:04Z

This is awesome. Keep in mind that we're also running a small code-and-learn at NodeConf EU at the beginning of November so some of the tasks may adjust after that. We should likely coordinate a bit in advance to make sure we don't end up duplicating any effort! :-) (I totally wish I was able to get to Tokyo this year)

One possible set of tasks that I can suggest for new contributors who are bit more confident in their Node.js skills, would be converting tests to use the new ../common/countdown utility module.

For instance, if you take a look at: https://github.com/nodejs/node/blob/master/test/parallel/test-http2-client-destroy.js, you'll see that there is a remaining counter (https://github.com/nodejs/node/blob/master/test/parallel/test-http2-client-destroy.js#L19). The test then counts down remaining before closing the server. There are quite a large number of tests in our suite that perform similar actions in ways that are rather inconsistent. The ../common/countdown utility was designed to bring some consistency there.

The way the Countdown utility works is straightforward:

const common = require('../common');
const Countdown = require('../common/countdown');

// ...

const countdown = new Countdown(n, common.mustCall(() => {
  // do something here
}));

// Decrement the counter, the callback is called synchronously when
// countdown.dec is called n times.
countdown.dec();

I know that there are quite a few of the http2 tests that can benefit from this, along with a bunch of other http and https tests.

These tasks would be for folks who are a bit more comfortable with their Node.js skills.

apapirovski · 2017-10-18T14:30:35Z

Another potential suggestion is replacing assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err); It's another thing I would like to ideally introduce an eslint rule for (already have it written) but there are currently a ton of instances where we use the former.

I think that's pretty similar in difficulty to the change that was done at Node.js Interactive this year.

AndreasMadsen · 2017-10-18T15:13:20Z

A simple thing is removing the redundant + from +conf.n in the benchmarks. If the values are integers in the bench(main, conf) object they will be integers in the main(conf) object too.

example: https://github.com/nodejs/node/blob/master/benchmark/assert/deepequal-object.js#L30L31

hiroppy · 2017-10-19T09:01:09Z

@jasnell @apapirovski @AndreasMadsen Thanks.🙌 I try to summarize that information in Gist.
You should come to Nodefest2017!!

MylesBorins · 2017-10-19T14:48:04Z

I can help! Any interest in running a values session similar to what we did at node interactive?

…

On Oct 19, 2017 5:01 AM, "Yuta Hiroto" ***@***.***> wrote: @jasnell <https://github.com/jasnell> @apapirovski <https://github.com/apapirovski> @AndreasMadsen <https://github.com/andreasmadsen> Thanks.🙌 I try to summarize that information in Gist. You should come to Nodefest2017!! — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#72 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecVwrKcRTYEduY19ofZjv5tBf_N2vsks5stw_XgaJpZM4P9VKJ> .

apapirovski · 2017-10-19T14:56:08Z

@abouthiroppy For my suggestion above, I created a gist with an eslint rule that will let you find all instances of assert.throws(fn, common.expectsError(err));.

hiroppy · 2017-10-20T00:47:56Z

@MylesBorins Thanks!! yep, but I don't know the values session of node interactive. Would you give me this information?

@apapirovski wow, thank you so much 🙇 I'll use it!

seishun · 2017-10-23T21:08:48Z

I'm on the fence about attending (concerned about the cost mostly).

fhinkel · 2017-11-11T08:44:44Z

Also, I will be there. Happy to help out with whatever needed.

hiroppy · 2017-11-18T06:17:17Z

Sorry for my late reply.

@seishun I think that Node.js Foundation will help with the cost.
@fhinkel Thanks!

Trott · 2017-11-18T06:53:53Z

@seishun I think that Node.js Foundation will help with the cost.

I don't think the foundation typically sends Collaborators to an event simply because it's a Node.js event. It's usually a Collaborator Summit. There have been some exceptions though, like sending particular people to a TC-39 meeting one time.

That said, there's absolutely nothing stopping any Collaborator from requesting funds from the TSC for something by opening an issue in the TSC repository.

MylesBorins · 2017-11-20T09:51:10Z

Have we prepared a list of changes for participants to implement?

How many people are we expecting?

yosuke-furukawa · 2017-11-20T09:52:06Z

I guess 30 - 50 people.

yosuke-furukawa · 2017-11-20T09:53:19Z

Have we prepared a list of changes for participants to implement?
Not yet !! I will create the list asap...

MylesBorins · 2017-11-20T09:57:48Z

I can help collect some changes after I run the Taiwan code and learn On Nov 20, 2017 4:53 AM, "Yosuke Furukawa" <notifications@github.com> wrote: Have we prepared a list of changes for participants to implement? Not yet !! I will create the list asap... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#72 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecV2P7RIvNo1FfAQ8eK5A-sJwbyhLpks5s4UwQgaJpZM4P9VKJ> .

hiroppy · 2017-11-20T11:21:22Z

a list of changes for participants

TODO	file	line	note
Fix typo	doc/api/util.md	695	occuring
Add link of `ECMAScript 2015`	doc/api/buffer.md	2740
Add link to `dns.resolve()`	doc/api/dns.md	632
Use `common.hasIntl` instead of `typeof Intl`	test/parallel/test-intl-v8BreakIterator.js	6
replace Function with Arrow Function	doc/api/util.md	442, 552, 567, 568
	test-writeint.js
	test-querystring.js
	test-assert.js
	test-http.js	109, 118, 127, 128
	test-http-pause.js
	doc/api/vm.md	477
	test-timers.js
	test-whatwg-url-searchparams-getall.js
	test-writeuint.js
	test-child-process-send-cb.js
	test-zerolengthbufferbug.js
	test-domain-top-level-error-handler-clears-stack.js
use `===` and `'`	test-whatwg-url-setters.js	43
add `;`	test-whatwg-url-setters.js	35, 81
make use of `const` or `let`	test-whatwg-url-setters.js	41 - 49
	many files....		find ./ -type f -print \| xargs grep var
fix comments	test-assert.js	617, 5292
make use of `Number.isNaN`	test-process-emit.js	22
	test-readdouble.js
	test-readfloat.js
	test-writedouble.js
	test-writefloat.js

please modify freely!

joyeecheung · 2017-11-21T20:25:21Z

We can try replacing all the google.com or this.hostname.is.invalid etc. references in test/parallel with configurable variables defined in internet.addresses

joyeecheung · 2017-11-21T20:27:10Z

Also there are a few tasks that could be more advanced: find the tests in test/parallel that are making actual dns calls, use mocked lookup functions or put those in test/internet. Searching for DNS error codes like EAI_AGAIN or ENOTFOUND in test/parallel would yield a bunch of tests that try to work around this even though they are not supposed to work around that.

joyeecheung · 2017-11-21T20:37:21Z

There is also nodejs/node#17169 , see nodejs/node#17169 (comment)

watilde · 2017-11-23T06:13:49Z

I've added some to #72 (comment).

joyeecheung · 2017-11-26T07:45:53Z

TODO	file	line
Replace `e->ToObject(env->isolate())` with `e->ToObject(env->context()).ToLocalChecked()`	src/node.cc	line 592
Replace `e->ToObject(env->isolate())` with `e->ToObject(env->context()).ToLocalChecked()`	src/node.cc	line 754
Replace `er->ToObject(env->isolate())` with `er->ToObject(env->context()).ToLocalChecked()`	src/node.cc	line 1485
Replace `args[0]->ToObject(env->isolate())` with `args[0]->ToObject(env->context()).ToLocalChecked()`	src/node.cc	line 2304
Replace `args[1]->ToString(env->isolate())` with `args[1]->ToString(env->context()).ToLocalChecked()`	src/node.cc	line 2322
Replace `module->Get(exports_string)->ToObject(env->isolate())` with `module->Get(exports_string)->ToObject(env->context()).ToLocalChecked()`	src/node.cc	line 2367
Replace `process_object->Get(exit_code)->ToInteger(env->isolate())` with `process_object->Get(exit_code)->ToInteger(env->context()).ToLocalChecked()`	src/node.cc	line 4340
Replace `args[1]->ToString(env->isolate())` with `args[1]->ToString(env->context()).ToLocalChecked()`	src/node_buffer.cc	line 609
Replace `args[0]->ToString(env->isolate())` with `args[0]->ToString(env->context()).ToLocalChecked()`	src/node_buffer.cc	line 680
Replace `args[0]->ToString(env->isolate())` with `args[0]->ToString(env->context()).ToLocalChecked()`	src/node_contextify.cc	line 624
Replace `args[1]->ToObject(env->isolate())` with `args[1]->ToObject(env->context()).ToLocalChecked()`	src/node_file.cc	line 1222
Replace `e->ToObject(env->isolate())` with `e->ToObject(env->context()).ToLocalChecked()`	src/node_http_parser.cc	line 469
Replace `args[1]->ToObject(env->isolate())` with `args[1]->ToObject(env->context()).ToLocalChecked()`	src/node_zlib.cc	line 181
Replace `args[4]->ToObject(env->isolate())` with `args[4]->ToObject(env->context()).ToLocalChecked()`	src/node_zlib.cc	line 190
Replace `args[0]->ToObject(env->isolate())` with `args[0]->ToObject(env->context()).ToLocalChecked()`	src/process_wrap.cc	line 146
Replace `chunk->ToString(env->isolate())` with `chunk->ToString(env->context()).ToLocalChecked()`	src/stream_base.cc	line 130
Replace `chunk->ToString(env->isolate())` with `chunk->ToString(env->context()).ToLocalChecked()`	src/stream_base.cc	line 182

This is generated with a script but should be a safe list

joyeecheung · 2017-11-26T07:46:09Z

Sorry, accidentally pressed the wrong button

kt3k · 2017-11-26T09:02:51Z

It was very fun! thank you!

hiroppy · 2017-11-26T11:19:35Z

@yosuke-furukawa @joyeecheung @MylesBorins Thank you for your help! I was really happy :)

1. Among the list of Code and Learn, I solved the unfinished task of replacing function with arrow function: nodejs/code-and-learn#72 (comment) 2. Replace arrow function with shorter property syntax Arrow function makes `this` lexical scope. But toString expects evaluate `this` in runtime. 3. Replace this with null makeBlock does not need `this`. update `this` with `null` to clarify the intent. PR-URL: #17345 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>

Fixes: nodejs/code-and-learn#72

PR-URL: nodejs#17803 Refs: nodejs/code-and-learn#72 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #17803 Refs: nodejs/code-and-learn#72 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#17803 Refs: nodejs/code-and-learn#72 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

vsemozhetbyt mentioned this issue Oct 18, 2017

tools: enable (sensible) additional eslint rules nodejs/node#16243

Closed

2 tasks

joyeecheung closed this as completed Nov 26, 2017

joyeecheung reopened this Nov 26, 2017

Leko mentioned this issue Nov 26, 2017

doc: Replace string with template string nodejs/node#17316

Closed

2 tasks

sara-o-mt2 mentioned this issue Nov 26, 2017

doc: Add link of ECMAScript 2015 nodejs/node#17317

Closed

2 tasks

koooge mentioned this issue Nov 26, 2017

test: use allow function nodejs/node#17318

Closed

3 tasks

fossamagna mentioned this issue Nov 26, 2017

test: use Number.isNaN() nodejs/node#17319

Closed

3 tasks

hiroppy closed this as completed Nov 26, 2017

This was referenced Nov 27, 2017

src: replace ->To*(isolate) with ->To*(context).ToLocalChecked() nodejs/node#17343

Closed

test: replace function with arrow function nodejs/node#17345

Closed

mithunsasidharan mentioned this issue Dec 8, 2017

test : lint and few minor fixes nodejs/node#17549

Closed

3 tasks

mithunsasidharan mentioned this issue Dec 13, 2017

cluster: use rest param & Reflect.apply nodejs/node#17655

Closed

3 tasks

sreepurnajasti mentioned this issue Dec 21, 2017

benchmark: Fix hack by removing redundant + nodejs/node#17803

Closed

2 tasks

sreepurnajasti added a commit to sreepurnajasti/node that referenced this issue Jan 5, 2018

benchmark: remove redundant +

994b9eb

Fixes: nodejs/code-and-learn#72

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code And Learn at NodeFest 2017 #72

Code And Learn at NodeFest 2017 #72

hiroppy commented Oct 18, 2017 •

edited

Loading

joyeecheung commented Oct 18, 2017

ronkorving commented Oct 18, 2017

vsemozhetbyt commented Oct 18, 2017 •

edited

Loading

hiroppy commented Oct 18, 2017

watilde commented Oct 18, 2017

jasnell commented Oct 18, 2017

apapirovski commented Oct 18, 2017 •

edited

Loading

AndreasMadsen commented Oct 18, 2017 •

edited

Loading

hiroppy commented Oct 19, 2017

MylesBorins commented Oct 19, 2017 via email

apapirovski commented Oct 19, 2017 •

edited

Loading

hiroppy commented Oct 20, 2017

seishun commented Oct 23, 2017

fhinkel commented Nov 11, 2017

hiroppy commented Nov 18, 2017

Trott commented Nov 18, 2017

MylesBorins commented Nov 20, 2017

yosuke-furukawa commented Nov 20, 2017

yosuke-furukawa commented Nov 20, 2017

MylesBorins commented Nov 20, 2017 via email

hiroppy commented Nov 20, 2017 •

edited

Loading

joyeecheung commented Nov 21, 2017 •

edited

Loading

joyeecheung commented Nov 21, 2017 •

edited

Loading

joyeecheung commented Nov 21, 2017

watilde commented Nov 23, 2017 •

edited

Loading

joyeecheung commented Nov 26, 2017

joyeecheung commented Nov 26, 2017

kt3k commented Nov 26, 2017

hiroppy commented Nov 26, 2017

Code And Learn at NodeFest 2017 #72

Code And Learn at NodeFest 2017 #72

Comments

hiroppy commented Oct 18, 2017 • edited Loading

Mentors

joyeecheung commented Oct 18, 2017

ronkorving commented Oct 18, 2017

vsemozhetbyt commented Oct 18, 2017 • edited Loading

hiroppy commented Oct 18, 2017

watilde commented Oct 18, 2017

jasnell commented Oct 18, 2017

apapirovski commented Oct 18, 2017 • edited Loading

AndreasMadsen commented Oct 18, 2017 • edited Loading

hiroppy commented Oct 19, 2017

MylesBorins commented Oct 19, 2017 via email

apapirovski commented Oct 19, 2017 • edited Loading

hiroppy commented Oct 20, 2017

seishun commented Oct 23, 2017

fhinkel commented Nov 11, 2017

hiroppy commented Nov 18, 2017

Trott commented Nov 18, 2017

MylesBorins commented Nov 20, 2017

yosuke-furukawa commented Nov 20, 2017

yosuke-furukawa commented Nov 20, 2017

MylesBorins commented Nov 20, 2017 via email

hiroppy commented Nov 20, 2017 • edited Loading

a list of changes for participants

joyeecheung commented Nov 21, 2017 • edited Loading

joyeecheung commented Nov 21, 2017 • edited Loading

joyeecheung commented Nov 21, 2017

watilde commented Nov 23, 2017 • edited Loading

joyeecheung commented Nov 26, 2017

joyeecheung commented Nov 26, 2017

kt3k commented Nov 26, 2017

hiroppy commented Nov 26, 2017

hiroppy commented Oct 18, 2017 •

edited

Loading

vsemozhetbyt commented Oct 18, 2017 •

edited

Loading

apapirovski commented Oct 18, 2017 •

edited

Loading

AndreasMadsen commented Oct 18, 2017 •

edited

Loading

apapirovski commented Oct 19, 2017 •

edited

Loading

hiroppy commented Nov 20, 2017 •

edited

Loading

joyeecheung commented Nov 21, 2017 •

edited

Loading

joyeecheung commented Nov 21, 2017 •

edited

Loading

watilde commented Nov 23, 2017 •

edited

Loading