Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: add co-authored-by-is-trailer #93

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

tniessen
Copy link
Member

This rule ensures that Co-authored-by is a trailer and does not appear at the beginning of any non-trailer lines. Violations of this rule have caused some commits to not be attributed to co-authors in the core repository.

cc @nodejs/build @nodejs/node-core-utils

Refs: nodejs/node-core-utils#602

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #93 (eb590e6) into main (1eca2be) will increase coverage by 0.77%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   74.88%   75.65%   +0.77%     
==========================================
  Files          18       19       +1     
  Lines         442      456      +14     
==========================================
+ Hits          331      345      +14     
  Misses        111      111              
Impacted Files Coverage Δ
lib/rules/co-authored-by-is-trailer.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eca2be...eb590e6. Read the comment docs.

@tniessen tniessen merged commit f991bbc into nodejs:main Jan 16, 2022
@tniessen tniessen deleted the co-authored-by-is-trailer branch January 16, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants